Review main Merged

38704[TASK] Simplify PHP lint execution

Mathias Brodala CR +2 V +2 Easy +1 −6 updated 04/16/15, 07:33

Commit message

This simplifies PHP lint execution in Travis by ensuring lint
errors are outputted to stderr and drops everything else. If
any check fails, the exit code 1 is returned.

The Composer vendor directory is excluded from linting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 12

  1. Mathias Brodala uploaded patch set 1 04/15/15, 13:02

  2. Christian Kuhn commented on patch set 1 CR +2 V +2 04/15/15, 13:54

    Fine after discussion and test run on catharsis: * Catharsis green with patch applied: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/58598781 * Catharsis red with patch applied and a syntax error in index.php: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/58598864
  3. Christian Kuhn commented on patch set 1 04/15/15, 13:57

    btw: maybe we should exclude typo3/contrib/vendor from linting - it doesn't make much sense to test 3rd party stuff that is just fetched in via composer?
  4. Christian Kuhn voted on patch set 1 CR +1 V +1 04/15/15, 14:15

  5. Christian Kuhn commented on patch set 1 CR 0 V 0 04/15/15, 14:16

    Mathias will include the vendor exeption ...
  6. Mathias Brodala uploaded patch set 2 04/15/15, 14:17

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 04/15/15, 15:16

  8. Christian Kuhn commented on patch set 2 04/15/15, 20:11

    since this one only changes our test environment, i'll take the freedom to merge that in some hours, even if we're in stabilization phase at the moment.
  9. Wouter Wolters commented on patch set 2 V +1 CR +1 04/15/15, 20:18

    pre merge test rus fine
  10. Markus Klein voted on patch set 2 CR +1 04/15/15, 21:33

  11. Christian Kuhn voted on patch set 2 CR +2 V +2 04/16/15, 07:32

  12. Christian Kuhn merged patch set 2 04/16/15, 07:33