38704[TASK] Simplify PHP lint execution
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 1
Files 1
Review log 12
-
Mathias Brodala uploaded patch set 1 04/15/15, 13:02
-
Christian Kuhn commented on patch set 1 CR +2 V +2 04/15/15, 13:54
Fine after discussion and test run on catharsis: * Catharsis green with patch applied: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/58598781 * Catharsis red with patch applied and a syntax error in index.php: https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/58598864 -
Christian Kuhn commented on patch set 1 04/15/15, 13:57
btw: maybe we should exclude typo3/contrib/vendor from linting - it doesn't make much sense to test 3rd party stuff that is just fetched in via composer? -
Christian Kuhn voted on patch set 1 CR +1 V +1 04/15/15, 14:15
-
Christian Kuhn commented on patch set 1 CR 0 V 0 04/15/15, 14:16
Mathias will include the vendor exeption ... -
Mathias Brodala uploaded patch set 2 04/15/15, 14:17
-
Christian Kuhn voted on patch set 2 CR +1 V +1 04/15/15, 15:16
-
Christian Kuhn commented on patch set 2 04/15/15, 20:11
since this one only changes our test environment, i'll take the freedom to merge that in some hours, even if we're in stabilization phase at the moment. -
Wouter Wolters commented on patch set 2 V +1 CR +1 04/15/15, 20:18
pre merge test rus fine -
Markus Klein voted on patch set 2 CR +1 04/15/15, 21:33
-
Christian Kuhn voted on patch set 2 CR +2 V +2 04/16/15, 07:32
-
Christian Kuhn merged patch set 2 04/16/15, 07:33