38727[BUGFIX] Support SVG without XML prologue
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Andreas Kienast +1
-
Verified V +2
- Frans Saris +2
- Andreas Kienast +1
Issues 1
Files 3
Review log 27
Show 2 earlier messages
-
Frank Nägler commented on patch set 1 CR -1 04/16/15, 10:41
on it -
Frank Nägler uploaded patch set 2 04/16/15, 10:57
-
Mathias Schreiber updated the commit message in patch set 3 04/16/15, 10:59
-
Frans Saris commented on patch set 3 04/16/15, 11:24
DefaultConfiguration.php:274does not work.. -
Frank Nägler uploaded patch set 4 04/16/15, 12:19
-
Frank Nägler uploaded patch set 5 04/16/15, 12:21
-
Frank Nägler updated the commit message in patch set 6 04/16/15, 12:24
-
Frank Nägler updated the commit message in patch set 7 04/16/15, 12:25
-
Frans Saris voted on patch set 7 CR +1 04/16/15, 20:27
-
Andreas Kienast uploaded patch set 8 04/18/15, 12:06
-
Andreas Kienast voted on patch set 8 CR +1 04/18/15, 12:06
-
Frans Saris voted on patch set 8 V +1 CR +1 04/19/15, 18:45
-
Markus Klein commented on patch set 8 04/19/15, 19:08
DefaultConfiguration.php:274correctlyBugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2I wouldn't expect a new config option hidden in a bugfix! I opt for FEATURE here -
Frank Nägler commented on patch set 8 04/20/15, 08:30
Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2Replygeneral I agree, but we discussed this some days ago, it is a new setting, but it is a bugfix. The bugfix need a new setting. What did you think about adding a second rst file with a feature description? -
Markus Klein commented on patch set 8 04/20/15, 11:28
Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2ReplyOn Gerrit this is a BUGFIX, but the rst should be called a feature, IMHO. So if someone works through the rsts he will find that. -
Frans Saris commented on patch set 8 04/20/15, 12:15
Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2ReplyYes this is a feature. A feature we need to fix a bug. -
Frank Nägler commented on patch set 8 04/20/15, 12:19
Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2ReplySo, only rename the rst file or add a second rst file? -
Markus Klein commented on patch set 8 04/20/15, 12:26
Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2ReplyOnly rename the rst. -
Frank Nägler uploaded patch set 9 04/20/15, 13:09
-
Frank Nägler commented on patch set 9 04/20/15, 13:09
only renamed rst files, please revote -
Frans Saris voted on patch set 9 CR +1 V +1 04/20/15, 14:55
-
Andreas Kienast updated the commit message in patch set 10 04/20/15, 15:06
-
Andreas Kienast commented on patch set 10 CR +1 V +1 04/20/15, 15:06
Sorry :/ -
Frans Saris voted on patch set 10 CR +2 V +2 04/20/15, 17:09
-
Frans Saris merged patch set 10 04/20/15, 17:09
FileInfo.php:31