Review main Merged

38727[BUGFIX] Support SVG without XML prologue

Frank Nägler CR +2 V +2 Easy +40 −5 updated 04/20/15, 17:09

Commit message

If a SVG does not contains a XML prologue, TYPO3 indexes this file with
mimetype text/plain, which results in missing width and height in the
database. This patch adds a mapping for known filetypes to support
also files which mimetype can not detected automatically.

Review

  • Code review CR +2
    • Frans Saris +2
    • Andreas Kienast +1
  • Verified V +2
    • Frans Saris +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 27

Show 2 earlier messages
  1. Frank Nägler uploaded patch set 1 04/16/15, 09:52

  2. Frans Saris commented on patch set 1 04/16/15, 10:06

    FileInfo.php:31

    IMO this should be in configuration so you can extend it
  1. Frank Nägler commented on patch set 1 CR -1 04/16/15, 10:41

    on it
  2. Frank Nägler uploaded patch set 2 04/16/15, 10:57

  3. Mathias Schreiber updated the commit message in patch set 3 04/16/15, 10:59

  4. Frans Saris commented on patch set 3 04/16/15, 11:24

    DefaultConfiguration.php:274

    does not work..
  5. Frank Nägler uploaded patch set 4 04/16/15, 12:19

  6. Frank Nägler uploaded patch set 5 04/16/15, 12:21

  7. Frank Nägler updated the commit message in patch set 6 04/16/15, 12:24

  8. Frank Nägler updated the commit message in patch set 7 04/16/15, 12:25

  9. Frans Saris voted on patch set 7 CR +1 04/16/15, 20:27

  10. Andreas Kienast uploaded patch set 8 04/18/15, 12:06

  11. Andreas Kienast voted on patch set 8 CR +1 04/18/15, 12:06

  12. Frans Saris voted on patch set 8 V +1 CR +1 04/19/15, 18:45

  13. Markus Klein commented on patch set 8 04/19/15, 19:08

    DefaultConfiguration.php:274

    correctly

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2

    I wouldn't expect a new config option hidden in a bugfix! I opt for FEATURE here
  14. Frank Nägler commented on patch set 8 04/20/15, 08:30

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2 Reply

    general I agree, but we discussed this some days ago, it is a new setting, but it is a bugfix. The bugfix need a new setting. What did you think about adding a second rst file with a feature description?
  15. Markus Klein commented on patch set 8 04/20/15, 11:28

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2 Reply

    On Gerrit this is a BUGFIX, but the rst should be called a feature, IMHO. So if someone works through the rsts he will find that.
  16. Frans Saris commented on patch set 8 04/20/15, 12:15

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2 Reply

    Yes this is a feature. A feature we need to fix a bug.
  17. Frank Nägler commented on patch set 8 04/20/15, 12:19

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2 Reply

    So, only rename the rst file or add a second rst file?
  18. Markus Klein commented on patch set 8 04/20/15, 12:26

    Bugfix-66445-AddFileExtensionToMimeTypeMapping.rst:2 Reply

    Only rename the rst.
  19. Frank Nägler uploaded patch set 9 04/20/15, 13:09

  20. Frank Nägler commented on patch set 9 04/20/15, 13:09

    only renamed rst files, please revote
  21. Frans Saris voted on patch set 9 CR +1 V +1 04/20/15, 14:55

  22. Andreas Kienast updated the commit message in patch set 10 04/20/15, 15:06

  23. Andreas Kienast commented on patch set 10 CR +1 V +1 04/20/15, 15:06

    Sorry :/
  24. Frans Saris voted on patch set 10 CR +2 V +2 04/20/15, 17:09

  25. Frans Saris merged patch set 10 04/20/15, 17:09