38763[BUGFIX] Show full folder path in file list title
Commit message
Review
-
Code review CR +2
- Frans Saris +2
- Christian Weiske +1
- Michael Oehlhof +1
-
Verified V +2
- Frans Saris +2
- Christian Weiske +1
- Michael Oehlhof +1
Issues 1
Files 3
Review log 33
Show 8 earlier messages
-
Christian Weiske uploaded patch set 1 04/17/15, 15:26
-
Frans Saris commented on patch set 1 CR -1 04/21/15, 15:52
I don't think it is save to assume that root folder identifier is /. Maybe just check if current identifier is the same as the parent or as root folder identifier. If I'm not mistaken you can ask the storage for the root folder -
Christian Weiske uploaded patch set 2 04/23/15, 13:07
-
Christian Weiske uploaded patch set 3 04/23/15, 13:08
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 04/23/15, 17:04
-
Christian Weiske uploaded patch set 4 04/24/15, 07:01
-
Michael Oehlhof voted on patch set 4 CR +1 V +1 04/24/15, 07:44
-
Andreas Kienast commented on patch set 4 CR -1 04/24/15, 07:53
Folder.php:106NULLFolder.php:107NULLFolder.php:111Can you put this into a variable as the same string is part of the return statement below?
-
Michael Oehlhof uploaded patch set 5 04/24/15, 12:13
-
Christian Weiske voted on patch set 5 CR +1 V +1 04/24/15, 12:18
-
Michael Oehlhof uploaded patch set 6 04/24/15, 12:19
-
Michael Oehlhof commented on patch set 6 04/24/15, 12:20
I've optimized a bit to get the code clearer. -
Christian Weiske voted on patch set 6 CR +1 V +1 04/24/15, 12:25
-
Markus Klein commented on patch set 6 04/24/15, 12:42
Folder.php:114isn't the / specific to file systems? What about drivers with no hierarchy? The / does not make sense then. -
Christian Weiske commented on patch set 6 04/24/15, 12:48
Could we leave this point (drivers with no hierarchy) please to the point until we actually have such a one? -
Michael Oehlhof commented on patch set 6 04/24/15, 13:31
It is the display name of the actual and all parent folders. So we have a hierarchy here. I think a folder in a non hierarchical driver would have no parent folder and a / at the end do not disturb. -
Markus Klein commented on patch set 6 CR +1 04/24/15, 16:19
alright, fine with me. ;-) -
Markus Klein commented on patch set 6 04/24/15, 16:20
Still one more question: Can we have a unittest for this? -
Sascha Egerer commented on patch set 6 CR -1 05/08/15, 18:21
Folder.php:114ReplyYes this does not make sense with non hierachical drivers. IMOO the readable path must be provided by the driver. -
Sascha Egerer commented on patch set 6 05/08/15, 18:24
@Christian Weiske > Could we leave this point (drivers with no hierarchy) please to the point until we actually have such a one? We are currently working on one for CMIS. See http://blog.dkd.de/typo3-cms-fal-for-cmis/ https://github.com/dkd/typo3-ext-cmis-fal https://github.com/dkd/typo3-ext-cmis-service https://github.com/dkd/php-cmis-client -
Christian Weiske commented on patch set 6 05/09/15, 08:01
As far as I see your "problem" lies in the fact that the file list shows "foldername/" instead of "foldername" only, for non-hierarchical file systems. But it's a >file list<. The files are inherently within the given folder, so having "foo/" as folder name is fine, because the full path of file.png is foo/file.png. I really cannot understand what the problem is. -
Sascha Egerer commented on patch set 6 CR 0 05/15/15, 12:39
As already said IMOO the path should be build by the driver and not by the Folder object itself. But thats just my point of view - I'm open for discussions. -
Stefan Neufeind commented on patch set 6 CR -1 05/16/15, 21:35
imho get rid of the trailing slashFolder.php:114ReplyIf you ask for just the path, maybe that should contain no slash at all? If you intend to concat that with a filename you might want to provide the slash inbetween yourself. But until then we might be fine to go without a slash imho. -
Michael Oehlhof commented on patch set 6 05/16/15, 22:58
Folder.php:114ReplyThe complete path is now: rootdir/subdir/subsubdir/ When we change it to move the / from the end to the beginning the complete path will be: /rootdir/subdir/subsubdir OK with that? -
Frans Saris commented on patch set 6 CR +1 05/17/15, 08:36
Maybe also use the new method in the ElementInfoControllerFolder.php:114ReplyI would leave the trailing slash. Makes it better visible for the user that this is a path. This method is only used to show a readable path as not all storages use identifiers that are a path. But we also do not want to add a function to the driver only to handle some UI stuff. IMO that doesn't belong to the driver but here. -
Frans Saris uploaded patch set 7 05/20/15, 19:40
-
Frans Saris voted on patch set 7 CR +1 V +1 05/20/15, 19:41
-
Christian Weiske voted on patch set 7 CR +1 V +1 05/20/15, 19:46
-
Michael Oehlhof voted on patch set 7 CR +1 V +1 05/20/15, 20:22
-
Frans Saris voted on patch set 7 CR +2 V +2 05/20/15, 20:25
-
Frans Saris merged patch set 7 05/20/15, 20:25
-
Frans Saris commented on patch set 8 05/20/15, 20:26
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 1fcf4e1a3de2b7d47e1b7337c1c3dce31e832d8b -
Xavier Perseguers commented on patch set 8 05/26/15, 14:48
Post -2 since it breaks environments with multiple mount points. Please see https://forge.typo3.org/issues/67148 for details