Review main Merged

38783[BUGFIX] Avoid double-encoding of URL parameters

Andreas Kienast CR +2 V +2 Easy +8 −9 updated 04/18/15, 13:08

Commit message

Fix some double rawurlencode() on parameters in EditDocumentController.

In almost all cases the getModuleUrl() method is now used, which already
takes care of proper URL encoding.

This also prevents errors where the CSRF protection failed due to wrong
URL encoding.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 04/18/15, 11:59

  2. Markus Klein uploaded patch set 2 04/18/15, 12:53

  3. Markus Klein uploaded patch set 3 04/18/15, 12:55

  4. Markus Klein voted on patch set 3 CR +1 V +1 04/18/15, 12:56

  5. Andreas Kienast voted on patch set 3 CR +2 V +2 04/18/15, 13:08

  6. Andreas Kienast merged patch set 3 04/18/15, 13:08