Review main Merged

38798[BUGFIX] Remove superfluous linebreaks in CE preview

Markus Klein CR +2 V +2 Easy +12 −6 updated 04/21/15, 19:52

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 10

  1. Markus Klein uploaded patch set 1 04/19/15, 11:54

  2. Andreas Kienast commented on patch set 1 V +1 04/20/15, 13:13

    ImagePreviewRenderer.php:50

    !empty($description) instead?
  3. Markus Klein commented on patch set 1 04/20/15, 13:29

    ImagePreviewRenderer.php:50 Reply

    dangerous: description could be '0'
  4. Andreas Kienast voted on patch set 1 CR +1 04/20/15, 13:30

  5. Frans Saris commented on patch set 1 04/20/15, 18:05

    ImagePreviewRenderer.php:41

    Should this linebreak not be kept? Now the descriptions start direct after/beside the images instead of below the images.
  6. Markus Klein commented on patch set 1 04/20/15, 18:17

    ImagePreviewRenderer.php:41 Reply

    Does it? How to reproduce? With only 1 image?
  7. Frans Saris commented on patch set 1 04/20/15, 18:55

    added 2 screenshots to forge
  8. Markus Klein commented on patch set 1 04/20/15, 19:21

    ImagePreviewRenderer.php:41 Reply

    Thanks for the images. I guess that has to stay then.
  9. Benni Mack voted on patch set 1 CR +2 V +2 04/21/15, 19:52

  10. Benni Mack merged patch set 1 04/21/15, 19:52