38798[BUGFIX] Remove superfluous linebreaks in CE preview
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Andreas Kienast +1
-
Verified V +2
- Benni Mack +2
- Andreas Kienast +1
Issues 1
Files 2
Review log 10
-
Markus Klein uploaded patch set 1 04/19/15, 11:54
-
Andreas Kienast commented on patch set 1 V +1 04/20/15, 13:13
-
Markus Klein commented on patch set 1 04/20/15, 13:29
ImagePreviewRenderer.php:50Replydangerous: description could be '0' -
Andreas Kienast voted on patch set 1 CR +1 04/20/15, 13:30
-
Frans Saris commented on patch set 1 04/20/15, 18:05
ImagePreviewRenderer.php:41Should this linebreak not be kept? Now the descriptions start direct after/beside the images instead of below the images. -
Markus Klein commented on patch set 1 04/20/15, 18:17
ImagePreviewRenderer.php:41ReplyDoes it? How to reproduce? With only 1 image? -
Frans Saris commented on patch set 1 04/20/15, 18:55
added 2 screenshots to forge -
Markus Klein commented on patch set 1 04/20/15, 19:21
ImagePreviewRenderer.php:41ReplyThanks for the images. I guess that has to stay then. -
Benni Mack voted on patch set 1 CR +2 V +2 04/21/15, 19:52
-
Benni Mack merged patch set 1 04/21/15, 19:52
ImagePreviewRenderer.php:50