Review main Merged

38871[BUGFIX] Add required to classStdWrap to avoid broken class names

Jo Hasenau CR +2 V +2 Easy +7 −0 updated 05/08/15, 08:52

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 11

  1. Jo Hasenau uploaded patch set 1 04/23/15, 10:38

  2. Jo Hasenau commented on patch set 1 04/23/15, 10:41

    Even though there is a check for !empty in the PHP code, you can still add stdWrap methods in your TypoScript settings which then could empty an existing value. This is why there is still a need for "required" to avoid wrapping empty values.
  3. Markus Klein voted on patch set 1 CR +1 04/23/15, 11:01

  4. Jo Hasenau uploaded patch set 2 04/23/15, 11:07

  5. Andreas Kienast voted on patch set 2 CR +1 V +1 04/23/15, 11:32

  6. Markus Klein commented on patch set 2 04/23/15, 23:06

    6.2 too now?
  7. Wouter Wolters voted on patch set 2 CR +1 04/28/15, 20:03

  8. Benni Mack voted on patch set 2 CR +2 V +2 05/08/15, 01:59

  9. Benni Mack commented on patch set 2 05/08/15, 02:02

    Although this is broken in 6.2 as well AFAIK I do not like to modify the FE output for 99% of all 6.2 sites in a minor release. So I prefer master-only. Markus, OK for you?
  10. Markus Klein commented on patch set 2 05/08/15, 08:51

    sure!
  11. Markus Klein merged patch set 2 05/08/15, 08:52