Review main Merged

38953[TASK] Add support for SPATIAL index type

Morton Jonuschat CR +2 V +2 Easy +44 −6 updated 05/08/15, 20:51

Commit message

Add support for "SPATIAL" keys to the SqlSchemaMigrationService.

Ignoring the subpart/key length for this type of index is required as
MySQL does not support specifying the length when creating/modifying
the index but reports this information when retrieving keys for a
table.

This change has been verified against MySQL 5.5.42 (Mac OS X) as well
as Percona Server 5.6.23 (Release 72.1, Linux).

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stephan Großberndt +1
  • Verified V +2
    • Christian Kuhn +2
    • Stephan Großberndt +1

Issues 1

Files 2

Review log 26

Show 1 earlier messages
  1. Morton Jonuschat uploaded patch set 1 04/27/15, 11:09

  1. Andreas Kienast commented on patch set 1 04/27/15, 18:07

    SqlSchemaMigrationService.php:193

    !==

    SqlSchemaMigrationService.php:200

    You may change this to === please?

    SqlSchemaMigrationService.php:202

    ===
  2. Morton Jonuschat uploaded patch set 2 04/27/15, 18:12

  3. Andreas Kienast voted on patch set 2 CR +1 04/27/15, 18:14

  4. Christian Kuhn commented on patch set 2 05/04/15, 12:01

    this class already has some unit tests for similar cases. it would be great to have another one for this case.
  5. Morton Jonuschat uploaded patch set 3 05/04/15, 16:50

  6. Stephan Großberndt commented on patch set 3 CR +1 05/04/15, 17:40

    SqlSchemaMigrationServiceTest.php:252

    getDatabaseExtraFindsSpatialKeys()?
  7. Morton Jonuschat commented on patch set 3 05/04/15, 18:12

    Wouldn't getDatabaseExtraFindsSpatialKeys() be another test? I would interpret the function name that it finds keys already existing in the database and doesn't want to perform a migration.
  8. Mathias Schreiber commented on patch set 3 CR -1 05/05/15, 17:41

    on it
  9. Mathias Schreiber voted on patch set 3 CR 0 05/06/15, 07:49

  10. Stephan Großberndt commented on patch set 3 V +1 05/06/15, 18:23

    How to verify: spatialfield point DEFAULT '' NOT NULL, SPATIAL INDEX spatialfield (spatialfield), to fe_users and verifying install tool does no longer wants to drop and recreate the spatial index. If you get "Cannot get geometry object from data you send to the GEOMETRY field": a spatial index can only be created if all rows contain valid data. Add it with UPDATE `fe_users` SET spatialfield=GeomFromText('POINT(1 1)');
  11. Xavier Perseguers commented on patch set 3 05/07/15, 19:01

    Add support for "SPATIAL" keys to...

    SqlSchemaMigrationServiceTest.php:255

    why is it indented twice with tabs?
  12. Xavier Perseguers commented on patch set 3 05/07/15, 19:02

    This looks like a FEATURE more than a real BUGFIX and I would tend to merge it into master solely, I see no real benefit for it in 6.2 apart for possible regressions
  13. Stephan Großberndt commented on patch set 3 05/07/15, 19:03

    The benefit is the bugfix: TYPO3 Install tool no longer complaining about SPATIAL index.
  14. Stephan Großberndt updated the commit message in patch set 4 05/07/15, 19:04

  15. Stephan Großberndt voted on patch set 4 CR +1 V +1 05/07/15, 19:04

  16. Morton Jonuschat uploaded patch set 5 05/08/15, 06:32

  17. Morton Jonuschat commented on patch set 5 05/08/15, 06:32

    Fixed indentation
  18. Stephan Großberndt voted on patch set 5 CR +1 V +1 05/08/15, 10:39

  19. Stephan Großberndt commented on patch set 5 05/08/15, 10:42

  20. Christian Kuhn commented on patch set 5 CR -1 05/08/15, 18:40

    working on it, stay tuned.
  21. Christian Kuhn updated the commit message in patch set 6 05/08/15, 19:05

  22. Christian Kuhn commented on patch set 6 CR +1 V +1 05/08/15, 19:07

    +1. The index is now handled correctly. Thx! However, the patch is imho more a task or feature than a bugfix. It is not critical and a rather seldom used thing. Thus, I'd say we should merge to master only, I removed the 6.2 from the releases line. Hope that is ok with everyone.
  23. Stephan Großberndt voted on patch set 6 CR +1 V +1 05/08/15, 20:06

  24. Christian Kuhn voted on patch set 6 CR +2 V +2 05/08/15, 20:51

  25. Christian Kuhn merged patch set 6 05/08/15, 20:51