Review main Merged

38958[BUGFIX] Respect cached page config

Andreas Kienast CR +2 V +2 Easy +4 −1 updated 07/13/15, 15:19

Commit message

On a cached page, initialise the page config only if it does not exist
yet. Merge the cached config with the template config to get the same
array as on a uncached page.

Review

  • Code review CR +2
    • Susi Moog +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Susi Moog +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 14

  1. Andreas Kienast uploaded patch set 1 04/27/15, 13:17

  2. Andreas Kienast updated the commit message in patch set 2 04/27/15, 13:18

  3. Markus Klein commented on patch set 2 CR -1 04/27/15, 13:20

    TypoScriptFrontendController.php:2507

    not a good idea: pagetitleseparator would be overwritten from the template, but should be kept from the cache
  4. Christian Kuhn commented on patch set 2 CR -1 04/27/15, 14:45

    Hmmm, correct me if I'm wrong, but I somehow have the feeling that this late change may introduce issues we did not see yet. Since this was done for the title thing, maybe we could live with he bug for now, release 7.2 and 6.2 and sort this one out later? Seems to be a bit risky at the moment. What do you think?
  5. Christian Kuhn commented on patch set 2 04/27/15, 14:46

    ah ok, was removed from sprint board already.
  6. Christian Kuhn voted on patch set 2 CR 0 04/27/15, 14:46

  7. Andreas Kienast commented on patch set 2 04/27/15, 14:58

    TypoScriptFrontendController.php:2507 Reply

    ArrayUtility::mergeRecursiveWithOverrule($this->tmpl->setup['config.'], $this->config['config']); $this->config['config'] = $this->tmpl->setup['config.']; This would work, but it looks wrong and I'm unsure if this is *the* solution.
  8. Andreas Kienast uploaded patch set 3 04/27/15, 15:29

  9. Markus Klein commented on patch set 3 CR +1 07/02/15, 19:04

    Looks good by reading, have to dig into the details again though.
  10. Nicole Hummel commented on patch set 3 CR -1 07/13/15, 12:11

    On it
  11. Nicole Hummel voted on patch set 3 CR +1 V +1 07/13/15, 12:45

  12. Susi Moog voted on patch set 3 CR +2 V +2 07/13/15, 13:57

  13. Nicole Hummel merged patch set 3 07/13/15, 15:19

  14. Nicole Hummel commented on patch set 4 07/13/15, 15:19

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 204adb0d65f9fa070114f3cec65fc72cc2d89495