Review main Abandoned

39050[BUGFIX] Inline elements (i.e. FAL) don't work in a flexform section

Bernhard Kraft CR 0 V 0 Normal +120 −41 updated 11/24/15, 14:19

Commit message

Creating inline elements like FAL fields inside a flexform repeatable
section does not work currently because the related tables have no
way of pointing to the flexform field which hosts the relation.

This patch introduces the necessary changes and adds a field
"flexform_field_foreign" to sys_file_reference as an example to make
FAL usable inside flexforms.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 14

Review log 8

  1. Bernhard Kraft uploaded patch set 1 04/28/15, 22:15

  2. Bernhard Kraft uploaded patch set 2 04/28/15, 22:45

  3. Bernhard Kraft commented on patch set 2 04/28/15, 22:50

    There is also an easier solution to make FAL fields work inside flexform sections. But this easier solution doesn't conform completly to the FAL specs as "uid_foreign" of sys_file_reference won't be set. Instead the UID of the sys_file_reference records will get stored in the flexform (section) fields. The approach is described/implemented here: https://github.com/FluidTYPO3/flux/pull/815
  4. Bernhard Kraft commented on patch set 2 04/28/15, 22:59

    If the approach of this page is ok I will add a changelog file and take care of writing a unit/functional test.
  5. Bernhard Kraft uploaded patch set 3 04/28/15, 23:08

  6. Benni Mack commented on patch set 3 07/17/15, 13:35

    Hey Bernhard, could you update that patch?
  7. Christian Kuhn abandoned the change 11/24/15, 08:19

    we're not sure if this should be implemented at all. furthermore, there was no work since initial push. abandoned for now.
  8. Bernhard Kraft commented on patch set 3 11/24/15, 14:19

    I had one request from a company if this would get integrated into the next version of TYPO3 CMS. But I couldn't give them a proper answer as this always requires some effort. There has been some discussion on github. In detail this posting by "Nameless coder" (part of the flux team) lead me to the conclusion the patch wouldn't be accepted: https://github.com/FluidTYPO3/flux/pull/815#issuecomment-102194382 He states, that section elements have no unique ID and therefor a static relation to elements inside a flexform section would not be possible. I counter argued that the index of a section element is static - at least this is what I observed when moving around elements. But in fact I did not try to delete, recreate, move, etc. sections around and even less did I look up the quite complicated flexforms code to have a look whether section id's are being kept static. If this would be the case there would have to be some "getMaxSectionIndex" method for creating new sections. So the reason for no further work on this issue is rather a lack of time and interest.