39053[BUGFIX] Use fully qualified class name for signals
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 22
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+11 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+5 −1
- typo3/sysext/backend/Classes/Form/DataPreprocessor.php+5 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −1
- typo3/sysext/backend/Classes/Utility/IconUtility.php+10 −2
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php+15 −3
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php+20 −4
- typo3/sysext/core/Classes/Resource/Service/FileProcessingService.php+10 −2
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+5 −1
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+124 −25
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+5 −1
- typo3/sysext/documentation/Classes/Controller/DocumentController.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −1
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+5 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+35 −7
- typo3/sysext/extensionmanager/Classes/Controller/ConfigurationController.php+5 −1
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+10 −2
- typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php+30 −6
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ProcessAvailableActionsViewHelper.php+1 −1
- typo3/sysext/impexp/Classes/Utility/ImportExportUtility.php+5 −1
Review log 9
-
Mathias Brodala uploaded patch set 1 04/29/15, 07:15
-
Andreas Kienast voted on patch set 1 CR +1 V +1 05/07/15, 07:10
-
Frank Nägler commented on patch set 1 CR -1 05/08/15, 23:43
I see no benefit for this patch. the main problem still exists. -
Christian Kuhn commented on patch set 1 CR -2 05/08/15, 23:46
I don't think this improves the overall situation: You're aiming to guard for developer stupidity if classes are moved around. This is not a technical improvement. Additionally, using the ::class thing could make the situation even worse if for example the phpstorm refactor feature is used to rename a class: the according signal identifier would be adapted, too. Maybe taking the class name as identifier is a bad idea in the first place, a "unique" identifier would be more suitable, for example the "timestamp now" - same logic we use for exeptions. We have a similar problem with hook arrays: all old hooks still contain t3lib/class.tcemain.php as identifier which is not a cool thing. So an identfier freed from the current class name would be much better to circumvent such clashed once and for all. -2 until this is fully sorted out, sorry for this blocker. -
Mathias Brodala commented on patch set 1 05/11/15, 07:49
I wasn't aware of the refactoring feature. In that case we should replace all identifiers with static strings instead (thus just like pre ::class era.) Would this also change upon refactoring? -
Christian Kuhn commented on patch set 1 05/11/15, 10:19
no, it wouldn't change. but it also does not help much. -
Mathias Brodala commented on patch set 1 05/11/15, 10:34
I did a quick check and in TYPO3.Flow there are also string literals used for dispatching signals. So maybe this is the way to go. -
Markus Klein commented on patch set 1 06/02/15, 22:51
I'm also for using plain strings. For new signals we should use speaking names independent of class names. Replacing the ::class just because phpstorm might rename them on refactoring is not a solution, since phpstorm is rather intelligent and also finds those class names in strings and does renames there as well. I ran into this multiple times in extensions. So IMO we can keep the ::class stuff. -
Mathias Brodala abandoned the change 06/03/15, 07:00
Alright then, let's find a more reliable solution.