Review main Merged

3907[FEATURE] Show Exception details only to BE users

Steffen Gebert CR +2 V +2 Normal +75 −14 updated 06/03/13, 20:49

Commit message

Change the ProductionExceptionHandler to show true error messages only
to authenticated Backend users (in Frontend and Backend).

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Philipp Gampe +1
  • Verified V +2
    • Xavier Perseguers +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 14

  1. Xavier Perseguers commented on patch set 2 08/02/11, 06:59

    Looks good to me, but someone else must approve
  2. Steffen Gebert uploaded patch set 2 08/02/11, 06:59

  3. Stefan Neufeind commented on patch set 3 08/02/11, 06:59

    Looks good to me, but someone else must approve
  4. Xavier Perseguers commented on patch set 3 V 0 08/02/11, 06:59

    by team member; Looks good to me, approved
  5. Georg Ringer commented on patch set 3 08/02/11, 06:59

    Looks good to me, but someone else must approve
  6. Steffen Gebert uploaded patch set 3 08/02/11, 06:59

  7. Philipp Gampe commented on patch set 2 08/02/11, 06:59

    I would prefer that you didn't submit this

    class.t3lib_error_productionexceptionhandler.php:93

    why ? I don't what to have "The page is not configured! [type=0][]. This means that there is no TypoScript object of type PAGE with typeNum=0 configured." published to public.

    class.t3lib_error_productionexceptionhandler.php:134

    a '/' is missing here! was already before or a '/' is too much in debug handler. Anyway the urls differ for no reason.
  8. Philipp Gampe commented on patch set 2 08/02/11, 06:59

    (1 inline comment) see comment
  9. Philipp Gampe commented on patch set 3 08/02/11, 06:59

    Verified; Looks good to me, but someone else must approve Works for me
  10. Jo Hasenau commented on patch set 2 08/02/11, 06:59

    Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 08/02/11, 06:59

  12. Mr. Jenkins commented on patch set 2 08/02/11, 06:59

  13. Mr. Jenkins commented on patch set 3 08/02/11, 06:59

  14. Xavier Perseguers merged patch set 3 08/02/11, 06:59