39083[BUGFIX] Make move button visibility independent of language mode
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 4
Review log 14
-
Jo Hasenau uploaded patch set 1 04/30/15, 11:24
-
Jan Helke voted on patch set 1 CR +1 V +1 04/30/15, 13:14
-
Christian Kuhn commented on patch set 1 05/01/15, 10:10
new option, gnaa ... could some ux person like benji / felix sign-off please? -
Frank Nägler commented on patch set 1 05/01/15, 12:52
instead of introduce an option for the up and down buttons, I would prefer to add an option for accessibility features on/off. which enable all these things, which are important for accessibility but conflicts with a best practice user experience. -
Jo Hasenau commented on patch set 1 05/01/15, 13:37
@Frank: The problem is that you can not group all these issue under on checkbox, sindc accessibility features differ between the target groups. Blind people with screenreaders need other things than plain keyboard users with full eye sight, who still need other features than mouse users with reduced eyesight but no screenreaders. So IMHO there can't be just one ring to bind them all ;-) What about an "Accessibility" tab within the user settings, that can then hold the different settings? -
Markus Klein commented on patch set 1 05/01/15, 13:48
of -
Frank Nägler commented on patch set 1 05/01/15, 13:48
hmm, I can follow your arguments. An own tab could be a good idea. I think accessibility is an important topic, and we will need more settings in future, because accessibility and usability will conflict more and more. -
Jo Hasenau uploaded patch set 2 05/01/15, 13:55
-
Benjamin Kott commented on patch set 2 V -1 05/14/15, 22:21
While i get the idea of making it more accessible for people with screenreaders - it should be nothing that needs to be enabled. We have enough options in html and css to make it accessible to users with these needs and hide if for those where its only take useful space away. Additionally is the sorting not working correctly and its not understandable where the elements get move to after klicking the sorting links. -
Jo Hasenau commented on patch set 2 05/15/15, 08:50
Well - accessibility is not just about screenreaders but about people who are forced to use the keyboard, because the either haven't got the ability to use a mouse or a touchscreen or they just haven't got the necessary devices. Currently keyboard users can not simply move elements unless they are using a very lengthy workaround by putting elements into the clipboard and pasting them in again. This is more ore less undoable since you have to perform a lot of keyboard actions to use the context menu for this purpose. The fact that moving elements does not work correctly is nothing I have been aware of, but it should not be an argument to remove the icons anyway. Instead we must fix that erratic behaviour. -
Jo Hasenau commented on patch set 2 05/15/15, 08:53
Just to clarify the reason for the option in the user settings: You can not identify keyboard users, unless they are blind keyboard users having a screenreader. So for people without an identifyable device we need something to make these icons usable. -
Benni Mack commented on patch set 2 03/31/16, 15:40
Hey Jo, is this one still relevant? -
Jo Hasenau commented on patch set 2 04/10/16, 12:36
Not sure - the issue is quite old. So first we'll have to clarify if this would be relevant enough for a fix in CMS 7, if it should be done just for master, or if it's just obsolete now. -
Benni Mack abandoned the change 10/19/17, 20:35
Sorting in PageLayoutView was removed, no activity in the last 2 years, so this topic will be closed.