Review main Merged

39089[BUGFIX] Prevent root folder listing for users

Nicole Hummel CR +2 V +2 Easy +29 −3 updated 05/02/15, 19:44

Commit message

If a user hasn't any file mount defined or the defined file mounts
don't exist the root folder of the storage is shown. To prevent
disallowed listing of folders only admin users are allowed see and
browse root folder and editors get an information that no file mounts
are configured.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
  • Verified V +2
    • Andreas Kienast +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 13

  1. Nicole Hummel uploaded patch set 1 04/30/15, 13:15

  2. Mathias Brodala commented on patch set 1 CR -1 04/30/15, 13:18

    Tiny nitpick.

    FolderTreeView.php:416

    Please "use" this.

    FolderTreeView.php:419

    Same here.
  3. Wouter Wolters voted on patch set 1 CR +1 04/30/15, 13:21

  4. Helmut Hummel commented on patch set 1 04/30/15, 14:36

    code looks good. I have minor comments regarding the messages…

    locallang.xlf:32

    No folders available

    locallang.xlf:35

    You do not have access to any folder. Please ask your administrator to fix access permissions for your account.
  5. Nicole Hummel uploaded patch set 2 04/30/15, 14:50

  6. Nicole Hummel commented on patch set 2 V -1 04/30/15, 15:13

    Will push an update
  7. Nicole Hummel commented on patch set 2 V 0 04/30/15, 15:15

    Okay, I thought about the rootLevelFolder but without any file mounts it is not accessible for users!
  8. Jan Helke voted on patch set 2 CR +1 V +1 04/30/15, 15:24

  9. Wouter Wolters commented on patch set 2 04/30/15, 17:00

    FolderTreeView.php:63

    change to getBackendUser as well
  10. Nicole Hummel uploaded patch set 3 04/30/15, 17:08

  11. Wouter Wolters voted on patch set 3 V +1 CR +1 05/02/15, 17:53

  12. Andreas Kienast voted on patch set 3 CR +2 V +2 05/02/15, 19:44

  13. Andreas Kienast merged patch set 3 05/02/15, 19:44