Review main Merged

39131[FEATURE] Add uppercamelcase and lowercamelcase to stdWrap.case

Frans Saris CR +2 V +2 Easy +39 −0 updated 05/02/15, 16:26

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 12

  1. Frans Saris uploaded patch set 1 05/01/15, 06:25

  2. Frans Saris uploaded patch set 2 05/01/15, 06:28

  3. Wouter Wolters voted on patch set 2 CR +1 05/01/15, 06:50

  4. Anja Leichsenring voted on patch set 2 CR +1 V +1 05/01/15, 09:25

  5. Xavier Perseguers commented on patch set 2 CR -1 05/01/15, 11:42

    typo

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:8

    Why is "LowerCamelCase" written with an upper L ? It's not an English word, so maybe use quotes around? and use the "standard" "lowerCamelCase" form?

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:18

    my_custOm_ctype
  6. Xavier Perseguers commented on patch set 2 V -1 05/01/15, 11:43

    doc will not render

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:10

    what's this syntax? .. code-block:: typoscript
  7. Frans Saris commented on patch set 2 05/01/15, 14:50

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:10 Reply

    The hint on forger is something with the block brackets and has ts as possibility what resulted in my creating this ;) will push new patch
  8. Frans Saris uploaded patch set 3 05/01/15, 14:59

  9. Frans Saris commented on patch set 2 05/01/15, 15:00

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:8 Reply

    Done

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:10 Reply

    Done

    Feature-66697-AddUppercamelcaseAndLowercamelcaseToStdWrap.case.rst:18 Reply

    Done
  10. Wouter Wolters voted on patch set 3 V +1 CR +1 05/02/15, 15:27

  11. Christian Kuhn voted on patch set 3 CR +2 V +2 05/02/15, 16:26

  12. Christian Kuhn merged patch set 3 05/02/15, 16:26