Review main Abandoned

39155[BUGFIX] Change POST data precedence

Jan Helke CR 0 V 0 Easy +21 −3 updated 06/25/15, 21:25

Commit message

This patch changes the behavior of getValue() such that
the POST value has higher priority than the default value
of the form field.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 8

  1. Jan Helke uploaded patch set 1 05/01/15, 12:51

  2. Markus Klein updated the commit message in patch set 2 05/01/15, 13:47

  3. Markus Klein updated the commit message in patch set 3 05/01/15, 13:47

  4. Christian Kuhn commented on patch set 3 05/01/15, 14:16

    sounds good on reading, but i'm not totally sure about possible impact ...
  5. Christian Müller commented on patch set 3 CR -1 05/01/15, 14:33

    This will break Checkbox and Radio ViewHelpers as they would have their value attribute overriden by the "state" that was last submitted. This is the (breaking) upstream fix: https://review.typo3.org/#/c/24794/
  6. Simon Schaufelberger commented on patch set 3 06/15/15, 20:27

    i think this can be abandoned, or?
  7. Benni Mack wrote 06/20/15, 08:17

    Topic set to fluid
  8. Christian Kuhn abandoned the change 06/25/15, 21:25

    this needs to be solved differently. i will abandon the patch for now, so we can start with a fresh attempt.