Review main Merged

39160[FEATURE] Add templateRootPaths support to StandaloneView

Frans Saris CR +2 V +2 Hard +257 −4 updated 05/04/15, 08:42

Commit message

StandaloneView is extended with setTemplateRootPaths() and
setTemplate() so it supports the same template path fallback
support like the extbase controllers do.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1

Issues 1

Files 3

Review log 17

  1. Frans Saris uploaded patch set 1 05/01/15, 15:30

  2. Markus Klein commented on patch set 1 05/01/15, 15:50

    right direction I'd say

    StandaloneView.php:198

    get!?
  3. Frans Saris commented on patch set 1 05/02/15, 19:51

    StandaloneView.php:198 Reply

    Why get? It doesn't return anything. The result is that setTemplatePathAndFilename() is called
  4. Wouter Wolters commented on patch set 1 05/02/15, 19:53

    StandaloneView.php:193

    missing type
  5. Markus Klein commented on patch set 1 05/02/15, 20:07

    StandaloneView.php:198 Reply

    I read two return statements at the end
  6. Frans Saris commented on patch set 1 05/02/15, 20:29

    StandaloneView.php:198 Reply

    Ah, the returns are wrong. Will remove them in next patch. setTemplatePathAndFilename() doesn't return anything
  7. Markus Klein commented on patch set 1 05/02/15, 20:37

    ok, looks good then

    StandaloneView.php:62

    string[] would be even better
  8. Frans Saris uploaded patch set 2 05/03/15, 09:23

  9. Frans Saris commented on patch set 1 05/03/15, 09:24

    StandaloneView.php:62 Reply

    Done

    StandaloneView.php:193 Reply

    Done

    StandaloneView.php:198 Reply

    Done
  10. Andreas Kienast commented on patch set 2 CR +1 V +1 05/03/15, 10:12

    verified by unit tests
  11. Wouter Wolters voted on patch set 2 CR +1 05/03/15, 10:14

  12. Anja Leichsenring voted on patch set 2 CR +2 V +2 05/03/15, 11:02

  13. Anja Leichsenring merged patch set 2 05/03/15, 11:02

  14. Mathias Brodala commented on patch set 3 05/04/15, 07:05

    Post -1.

    StandaloneView.php:199

    Why is $throwException ignored here? This makes that parameter very misleading as it implies that there will never be an exception if set to FALSE. In general I'd remove that parameter altogether.
  15. Frans Saris commented on patch set 3 05/04/15, 07:34

    StandaloneView.php:199 Reply

    As the default is TRUE I think we indeed should drop the parameter. Will push followup
  16. Frans Saris commented on patch set 3 05/04/15, 07:39

  17. Mathias Brodala commented on patch set 3 05/04/15, 08:42

    Thanks. :-)