39160[FEATURE] Add templateRootPaths support to StandaloneView
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Anja Leichsenring +2
- Andreas Kienast +1
Issues 1
Files 3
Review log 17
-
Frans Saris uploaded patch set 1 05/01/15, 15:30
-
Markus Klein commented on patch set 1 05/01/15, 15:50
right direction I'd sayStandaloneView.php:198get!? -
Frans Saris commented on patch set 1 05/02/15, 19:51
StandaloneView.php:198ReplyWhy get? It doesn't return anything. The result is that setTemplatePathAndFilename() is called -
Wouter Wolters commented on patch set 1 05/02/15, 19:53
StandaloneView.php:193missing type -
Markus Klein commented on patch set 1 05/02/15, 20:07
StandaloneView.php:198ReplyI read two return statements at the end -
Frans Saris commented on patch set 1 05/02/15, 20:29
StandaloneView.php:198ReplyAh, the returns are wrong. Will remove them in next patch. setTemplatePathAndFilename() doesn't return anything -
Markus Klein commented on patch set 1 05/02/15, 20:37
ok, looks good thenStandaloneView.php:62string[] would be even better -
Frans Saris uploaded patch set 2 05/03/15, 09:23
-
Frans Saris commented on patch set 1 05/03/15, 09:24
StandaloneView.php:62ReplyDoneStandaloneView.php:193ReplyDoneStandaloneView.php:198ReplyDone -
Andreas Kienast commented on patch set 2 CR +1 V +1 05/03/15, 10:12
verified by unit tests -
Wouter Wolters voted on patch set 2 CR +1 05/03/15, 10:14
-
Anja Leichsenring voted on patch set 2 CR +2 V +2 05/03/15, 11:02
-
Anja Leichsenring merged patch set 2 05/03/15, 11:02
-
Mathias Brodala commented on patch set 3 05/04/15, 07:05
Post -1.StandaloneView.php:199Why is $throwException ignored here? This makes that parameter very misleading as it implies that there will never be an exception if set to FALSE. In general I'd remove that parameter altogether. -
Frans Saris commented on patch set 3 05/04/15, 07:34
StandaloneView.php:199ReplyAs the default is TRUE I think we indeed should drop the parameter. Will push followup -
Frans Saris commented on patch set 3 05/04/15, 07:39
-
Mathias Brodala commented on patch set 3 05/04/15, 08:42
Thanks. :-)