Review main Merged

39181[BUGFIX] Prevent wrong information after extension upload

Nicole Hummel CR +2 V +2 Easy +7 −6 updated 05/02/15, 13:47

Commit message

If you upload an extension it is extracted and installed in separate
steps. If the extraction was successful a flash message is rendered.
If the installation fails the whole extension is removed again but the
flash message is still visible. This patch separates flash message output
for upload and installation process.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Jan Helke +1

Issues 1

Files 1

Review log 5

  1. Nicole Hummel uploaded patch set 1 05/02/15, 08:59

  2. Jan Helke voted on patch set 1 CR +1 V +1 05/02/15, 09:26

  3. Christian Kuhn voted on patch set 1 CR +2 V +2 05/02/15, 09:37

  4. Christian Kuhn merged patch set 1 05/02/15, 09:37

  5. Nicole Hummel commented on patch set 2 05/02/15, 13:47

    No backport needed as the feature https://review.typo3.org/30972/ wasn't backported either.