Review main Merged

39182[TASK] Improve retrieving distribution list

Nicole Hummel CR +2 V +2 Easy +31 −17 updated 05/02/15, 11:53

Commit message

If you open the "Get preconfigured distribution" extension manager
function the extension list is retrieved twice. Furthermore database
queries are executed multiple times. This patch improves retrieving the
extension list, prevents database queries and catches thrown errors to
prevent errors.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Helmut Hummel +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Helmut Hummel +2

Issues 1

Files 3

Review log 9

  1. Nicole Hummel uploaded patch set 1 05/02/15, 09:36

  2. Stephan Großberndt voted on patch set 1 CR +1 05/02/15, 11:22

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 05/02/15, 11:33

  4. Helmut Hummel commented on patch set 1 CR -1 05/02/15, 11:36

    on it now
  5. Helmut Hummel uploaded patch set 2 05/02/15, 11:45

  6. Helmut Hummel commented on patch set 2 CR +2 V +2 05/02/15, 11:46

    Works as advertised. Only updated comments and imports
  7. Wouter Wolters voted on patch set 2 CR +1 05/02/15, 11:48

  8. Anja Leichsenring voted on patch set 2 CR +2 V +2 05/02/15, 11:53

  9. Anja Leichsenring merged patch set 2 05/02/15, 11:53