Review main Merged

39207[TASK] Remove initializeArguments method from IconViewHelper

Anja Leichsenring CR +2 V +2 Easy +18 −21 updated 05/03/15, 09:57

Commit message

The initializeArguments method does not play well with
renderStatic. Therefore the registered argument is merged into the
render method attributes list.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 11

  1. Anja Leichsenring uploaded patch set 1 05/02/15, 17:16

  2. Wouter Wolters voted on patch set 1 V +1 CR +1 05/02/15, 18:56

  3. Andreas Kienast uploaded patch set 2 05/02/15, 19:05

  4. Andreas Kienast commented on patch set 1 05/02/15, 19:05

    fixed 2 nitpicks
  5. Andreas Kienast commented on patch set 2 CR -1 05/02/15, 19:09

    found something other, working on it
  6. Andreas Kienast uploaded patch set 3 05/02/15, 19:11

  7. Andreas Kienast commented on patch set 3 CR +1 V +1 05/02/15, 19:12

    We only need to iterate $additionalAttributes if we actually need it.
  8. Wouter Wolters voted on patch set 3 V +2 CR +2 05/02/15, 19:13

  9. Wouter Wolters merged patch set 3 05/02/15, 19:13

  10. Christian Kuhn commented on patch set 4 05/03/15, 09:54

    regression - i receive an exception from sys_note in page module if this patch is applied - must delete typo3temp/Cache before: #1237823695: Argument "additionalAttributes" was not registered. Triggered by sys_note template that hooks into page module.
  11. Christian Kuhn commented on patch set 4 05/03/15, 09:57

    jan is currently unable to reproduce, but i'd guess that is in sys_note/Resources/Private/Templates/Note/List.html: <f:be.buttons.icon uri="{notes:deleteLink(id:note.uid)}" icon="actions-edit-delete" additionalAttributes="{onClick: 'return confirm(\'{f:translate(key: \'LLL:EXT:lang/locallang_alt_doc.xlf:deleteWarning\')}\');'}" />