39209[BUGFIX] Improve dependency check in extension manager
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Anja Leichsenring +2
- Andreas Kienast +1
Issues 5
- Bug #52051Exception in ExtensionManager when installing without initially updating the repository
- Bug #65332Distribution: Exception thrown if depending extension isn't installed
- Feature #65479show versions with ExtensionManagerException downloaded in different version
- Bug #65916Installing a distribution with local extension repository
- Bug #60777(Re)activating an extension silently downgrades dependent extension
Files 7
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php2+3 −1
- typo3/sysext/extensionmanager/Classes/Domain/Model/DownloadQueue.php1+7 −4
- typo3/sysext/extensionmanager/Classes/Service/ExtensionManagementService.php+3 −1
- typo3/sysext/extensionmanager/Classes/Utility/Repository/Helper.php+3 −0
- typo3/sysext/extensionmanager/Classes/Utility/DependencyUtility.php+45 −7
- typo3/sysext/extensionmanager/Classes/Utility/ListUtility.php1+9 −0
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+3 −0
Review log 14
-
Nicole Hummel uploaded patch set 1 05/02/15, 17:33
-
Wouter Wolters commented on patch set 1 05/02/15, 17:50
DownloadQueue.php:72and -> translated? -
Andreas Kienast commented on patch set 1 CR -1 05/02/15, 17:50
I'm on it -
Andreas Kienast uploaded patch set 2 05/02/15, 18:11
-
Markus Klein updated the commit message in patch set 3 05/02/15, 18:28
-
Markus Klein commented on patch set 3 05/02/15, 18:31
nitpicksDownloadController.php:84please keep the <br />. I cite mattes: "HTML is for machines"ListUtility.php:94unknown -
Andreas Kienast commented on patch set 3 CR -1 05/02/15, 18:31
I changed it, I fix it -
Andreas Kienast uploaded patch set 4 05/02/15, 18:33
-
Nicole Hummel updated the commit message in patch set 5 05/02/15, 20:25
-
Nicole Hummel commented on patch set 5 05/02/15, 20:26
Added another ticket which is solved by this patch -
Andreas Kienast voted on patch set 5 CR +1 V +1 05/03/15, 09:04
-
Wouter Wolters voted on patch set 5 CR +1 05/03/15, 09:22
-
Anja Leichsenring voted on patch set 5 CR +2 V +2 05/03/15, 11:17
-
Anja Leichsenring merged patch set 5 05/03/15, 11:17
DownloadController.php:82