Review main Merged

39209[BUGFIX] Improve dependency check in extension manager

Nicole Hummel CR +2 V +2 Normal +73 −13 updated 05/03/15, 11:17

Commit message

This patch solves multiple problems currently occurring
if you try to install an extension:

* check dependencies recursively and merge errors
* prevent download if dependency errors occur
* prevent downgrading an extension
* improve information and error messages
* catch exceptions and display flash message

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Anja Leichsenring +2
    • Andreas Kienast +1

Issues 5

Files 7

Review log 14

  1. Nicole Hummel uploaded patch set 1 05/02/15, 17:33

  2. Wouter Wolters commented on patch set 1 05/02/15, 17:50

    DownloadController.php:82

    should new version be translated?

    DownloadQueue.php:72

    and -> translated?
  3. Andreas Kienast commented on patch set 1 CR -1 05/02/15, 17:50

    I'm on it
  4. Andreas Kienast uploaded patch set 2 05/02/15, 18:11

  5. Markus Klein updated the commit message in patch set 3 05/02/15, 18:28

  6. Markus Klein commented on patch set 3 05/02/15, 18:31

    nitpicks

    DownloadController.php:84

    please keep the <br />. I cite mattes: "HTML is for machines"

    ListUtility.php:94

    unknown
  7. Andreas Kienast commented on patch set 3 CR -1 05/02/15, 18:31

    I changed it, I fix it
  8. Andreas Kienast uploaded patch set 4 05/02/15, 18:33

  9. Nicole Hummel updated the commit message in patch set 5 05/02/15, 20:25

  10. Nicole Hummel commented on patch set 5 05/02/15, 20:26

    Added another ticket which is solved by this patch
  11. Andreas Kienast voted on patch set 5 CR +1 V +1 05/03/15, 09:04

  12. Wouter Wolters voted on patch set 5 CR +1 05/03/15, 09:22

  13. Anja Leichsenring voted on patch set 5 CR +2 V +2 05/03/15, 11:17

  14. Anja Leichsenring merged patch set 5 05/03/15, 11:17