Review TYPO3_6-2 Merged

39214[BUGFIX] Prevent root folder listing for users

Andreas Kienast CR +2 V +2 Easy +30 −4 updated 05/05/15, 07:33

Commit message

If a user hasn't any file mount defined or the defined file mounts
don't exist the root folder of the storage is shown. To prevent
disallowed listing of folders only admin users are allowed see and
browse root folder and editors get an information that no file mounts
are configured.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 2

Review log 13

  1. Andreas Kienast uploaded patch set 1 05/02/15, 19:55

  2. Andreas Kienast uploaded patch set 2 05/02/15, 19:56

  3. Nicole Hummel uploaded patch set 3 05/02/15, 20:22

  4. Nicole Hummel voted on patch set 3 CR +2 V +2 05/02/15, 20:22

  5. Markus Klein commented on patch set 3 CR -1 05/02/15, 22:08

    FolderTreeView.php:255

    where is that defined?

    FolderTreeView.php:294

    that's wrong I guess
  6. Andreas Kienast commented on patch set 3 05/02/15, 22:09

    FolderTreeView.php:255 Reply

    In AbstractTreeView

    FolderTreeView.php:294 Reply

    That's right, I'll pusha followup
  7. Markus Klein commented on patch set 3 05/02/15, 22:10

    FolderTreeView.php:255 Reply

    answer to myself: in parent class of course
  8. Andreas Kienast uploaded patch set 4 05/02/15, 22:12

  9. Markus Klein commented on patch set 4 05/02/15, 22:20

    locallang.xlf:6

    not used anymore. spaces do not have to be preserved here!
  10. Andreas Kienast uploaded patch set 5 05/02/15, 22:25

  11. Markus Klein voted on patch set 5 CR +1 V +1 05/02/15, 22:27

  12. Andreas Kienast voted on patch set 5 V +2 CR +2 05/05/15, 07:32

  13. Andreas Kienast merged patch set 5 05/05/15, 07:33