39235[TASK] Drop index length from "uid_foreign_tablefield"
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 7
-
Andreas Kienast uploaded patch set 1 05/03/15, 11:48
-
Andreas Kienast updated the commit message in patch set 2 05/03/15, 11:49
-
Christian Kuhn voted on patch set 2 CR +1 V +1 05/04/15, 11:59
-
Anja Leichsenring voted on patch set 2 CR +2 V +2 05/05/15, 19:40
-
Anja Leichsenring merged patch set 2 05/05/15, 19:40
-
Stefan Froemken commented on patch set 3 05/06/15, 06:25
Please revert this patch. It was pushed without verifying it. The amount in varchar represents the letters. The amount in index represents the bytes. As we decided to use UTF-8 years ago, each letter needs 3 bytes in db. So with this patch we try to allocate 1574 bytes now. MySQL default is 1000. Sometime 1024. That's resulting in following error in installtool: Error: Specified key was too long; max key length is 1000 bytes -
Markus Klein commented on patch set 3 05/11/15, 13:12
I had a closer look with Stefan on this issue. This is indeed a problem on real MySQL servers. All mariadb seem to be fine though. Still we need to find out, which configuration of the server might be a problem here.