39254[TASK] Improve .htaccess files
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Stephan Großberndt +1
-
Verified V +2
- Markus Klein +2
- Stephan Großberndt +1
Issues 2
Files 15
- typo3/sysext/about/Resources/Private/.htaccess+11 −1
- typo3/sysext/aboutmodules/Resources/Private/.htaccess+11 −1
- typo3/sysext/belog/Resources/Private/.htaccess+11 −1
- typo3/sysext/beuser/Resources/Private/.htaccess+11 −1
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+14 −1
- typo3/sysext/core/Documentation/Changelog/.htaccess+11 −1
- typo3/sysext/core/Resources/Private/.htaccess+11 −1
- typo3/sysext/extensionmanager/Resources/Private/.htaccess+11 −1
- typo3/sysext/install/Classes/Service/SessionService.php+14 −1
- typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/fileadmin-temp-htaccess+11 −2
- typo3/sysext/install/Resources/Private/FolderStructureTemplateFiles/fileadmin-user_upload-temp-importexport-htaccess+11 −2
- typo3/sysext/install/Resources/Private/.htaccess+11 −1
- typo3/sysext/lang/Resources/Private/.htaccess+11 −1
- typo3/sysext/taskcenter/Resources/Private/.htaccess+11 −1
- _.htaccess28+282 −87
Review log 71
Show 46 earlier messages
-
Andreas Kienast uploaded patch set 1 05/04/15, 09:16
-
Andreas Kienast uploaded patch set 2 05/04/15, 09:16
-
Stephan Großberndt voted on patch set 2 CR +1 05/04/15, 09:18
-
Markus Klein commented on patch set 2 05/04/15, 09:33
-
Andreas Kienast commented on patch set 2 05/04/15, 09:38
_.htaccess:115ReplyMaybe there's the case one links to a SQL file for downloading, which is placed somewhere in fileadmin. -
Andreas Kienast uploaded patch set 3 05/04/15, 11:26
-
Andreas Kienast uploaded patch set 4 05/04/15, 11:32
-
Stephan Großberndt voted on patch set 4 CR +1 05/04/15, 11:33
-
Stephan Großberndt voted on patch set 4 CR -1 05/04/15, 11:36
-
Stephan Großberndt commented on patch set 4 05/04/15, 11:37
_.htaccess:110Add rule here too. -
Markus Klein commented on patch set 4 CR -1 05/04/15, 11:38
_.htaccess:114these need to be extended for typo3/contrib as well_.htaccess:115/* is wrong. you mean: /.+\.sql$_.htaccess:115non-capturing group here: (?:conf) -
Andreas Kienast commented on patch set 4 CR -2 05/04/15, 12:13
.htaccess gets more improvements, I'm blocking this patch for the time being -
Andreas Kienast uploaded patch set 5 05/04/15, 13:55
-
Andreas Kienast commented on patch set 5 CR 0 05/04/15, 13:55
Released lock as it is WIP now -
Markus Klein commented on patch set 5 CR -2 05/04/15, 13:58
Misses a lot from the https://notes.typo3.org/p/.htaccess_improvments document. Will work in that tonight._.htaccess:113[*/] is wrong, must be [^/]_.htaccess:114if you use more groups then at least non-capturing ones. I prefer a simple list of paths inside 1 groups with alternation -
Frank Nägler commented on patch set 5 05/04/15, 14:01
Please add a rst file for this change, because the .htaccess file is mostly not part of an update. -
Frank Nägler commented on patch set 5 05/04/15, 14:13
please also a hint in the release notes! in 6.2 -
Stephan Großberndt commented on patch set 5 CR -1 05/04/15, 14:13
_.htaccess:114Why block Configuration and Resources/Private in /typo3/contrib? These are no common directories there. Why /[*/]+ in Configuration and [^/]+ in Resources? ^(?:typo3conf/ext|typo3/(?:sysext|ext))/[^/]+/Configuration/ ^(?:typo3conf/ext|typo3/(?:sysext|ext))/[^/]+/Resources/Private/_.htaccess:118^(?:ChangeLog|ToDo|Readme|License)\.(?:md|txt)? allows ChangeLog but prevents access to ChangeLog. ^(?:ChangeLog|ToDo|Readme|License)\.?(?:md|txt)? Does ext_(.*)\.txt need the braces? => ext_.*\.txt Same for locallang(.*)\.(xml|xlf) => locallang.*\.(?:xml|xlf) bak|conf => bak|co?nf|cfg sql(.*) => sql(?:.*) -
Stephan Großberndt uploaded patch set 6 05/04/15, 14:27
-
Stephan Großberndt commented on patch set 6 CR -1 05/04/15, 14:32
Still needs RST, mention in 6.2 release notes, more from https://notes.typo3.org/p/.htaccess_improvments I just wanted to fix the issues I spotted. -
Morton Jonuschat commented on patch set 6 05/04/15, 17:05
_.htaccess:111Isn't this line missing a \. after TYPO3root/ ? -
Markus Klein uploaded patch set 7 05/04/15, 23:48
-
Markus Klein commented on patch set 7 CR 0 05/04/15, 23:49
Yet untested. -
Markus Klein uploaded patch set 8 05/04/15, 23:50
-
Markus Klein uploaded patch set 9 05/04/15, 23:52
-
Andreas Kienast commented on patch set 9 05/05/15, 07:13
_.htaccess:305Sidenote: Shouldn't we also extend the default setting of "[EXT][excludeForPackaging]" by some of these values? -
Markus Klein commented on patch set 9 05/05/15, 08:25
Indeed, we should. -
Stephan Großberndt voted on patch set 9 CR +1 05/06/15, 08:04
-
Stephan Großberndt voted on patch set 9 CR 0 05/06/15, 08:04
-
Andreas Kienast updated the commit message in patch set 10 05/06/15, 08:28
-
Markus Klein commented on patch set 10 05/06/15, 08:35
I'll give this file a testing shot on a live-server soonish -
Stephan Großberndt voted on patch set 10 CR +1 05/06/15, 08:36
-
Stephan Großberndt commented on patch set 10 CR -1 05/06/15, 09:01
_.htaccess:284Why protect typo3/vendor/*/Configuration and typo3/vendor/*/Resources/Private? Those subdirectories are no common structure there and do not exist. -
Stephan Großberndt commented on patch set 10 05/06/15, 09:09
Tested this config: Put it in a separate file and included it from vhost.httpd. Fails because of "RewriteBase: only valid in per-directory config files " commented "RewriteBase /". Now I get 400-error "Your browser sent a request that this server could not understand." :-| Apache/2.2.22 (Debian) -
Markus Klein commented on patch set 10 CR -1 05/06/15, 09:29
This is still a draft. will add the [wip]_.htaccess:284Replybecause if you add exts via composer they reside there. -
Markus Klein updated the commit message in patch set 11 05/06/15, 09:29
-
Stephan Großberndt commented on patch set 10 05/06/15, 10:07
Ok, I just need to wrap the <IfModule mod_rewrite.c /> in <Directory /> </Directory> since I do include the configuration via Include from my vhost.httpd. Looks good so far!_.htaccess:284ReplyAh, ok, didn't use that so far. Then its fine. What about typo3conf\ext\*\static -
Stephan Großberndt voted on patch set 11 CR +1 05/06/15, 10:08
-
Stephan Großberndt commented on patch set 11 05/12/15, 10:22
_.htaccess:349This currently fails on IE, because ThumbnailView.php serves header('Content-type: image/'.$outext); resulting in Content-type: image/jpg instead of Content-type: image/jpeg. I'll create a bug report for it. That bug should be fixed before merging this. -
Stephan Großberndt voted on patch set 11 V -1 05/12/15, 10:22
-
Stephan Großberndt voted on patch set 11 CR 0 05/12/15, 10:22
-
Stephan Großberndt commented on patch set 11 CR -1 05/12/15, 10:22
_.htaccess:334Put all those mod_headers.c conditions into one? -
Markus Klein commented on patch set 11 05/12/15, 10:51
_.htaccess:334ReplyThought about that already, but I kept it separated due to different concern. This here is IE only._.htaccess:349ReplyAlright, thanks. -
Stephan Großberndt commented on patch set 11 05/12/15, 10:53
-
Wouter Wolters commented on patch set 11 05/12/15, 21:41
Take this one too? https://forge.typo3.org/issues/66235 -
Stephan Großberndt updated the commit message in patch set 12 05/12/15, 22:18
-
Markus Klein uploaded patch set 13 05/13/15, 12:36
-
Markus Klein uploaded patch set 14 05/13/15, 12:38
-
Markus Klein updated the commit message in patch set 15 05/13/15, 12:40
-
Stephan Großberndt commented on patch set 15 05/13/15, 13:43
_.htaccess:362This could be removed on master -
Xavier Perseguers commented on patch set 15 05/13/15, 14:10
Could we think about documenting somewhere (I think of the sample _.htaccess for Apache) how to configure Nginx in a similar manner? I mean Apache and Nginx are both widely used, we cannot automatically configure Nginx with htaccess but we could anyway document how to do it. Restricting access to Private directories is easily done but the whole speed enhancement + CORS would be much appreciated to Nginx admins. -
Markus Klein commented on patch set 15 05/13/15, 16:10
Would do the nginx docs separately. Mattes offered help here. Once we have this patch as a basis, we can easily deduce the according nginx rules. (which should also go into docs, I'd say) -
Stephan Großberndt uploaded patch set 16 06/30/15, 09:24
-
Stephan Großberndt commented on patch set 16 CR +1 V +1 06/30/15, 09:34
I use this setup for nearly two months now and it works fine. Are there any TODOs left why this should not be merged yet? I don't see any. -
Markus Klein commented on patch set 16 06/30/15, 10:25
_.htaccess:339trailing space -
Stephan Großberndt uploaded patch set 17 06/30/15, 10:27
-
Markus Klein voted on patch set 17 CR +1 V +1 06/30/15, 10:28
-
Stephan Großberndt voted on patch set 17 CR +1 V +1 06/30/15, 10:31
-
Mathias Brodala commented on patch set 17 06/30/15, 10:33
_.htaccess:260What's the purpose for this? (Aside from "it's used afterwards." ;-) ) -
Mathias Brodala uploaded patch set 18 06/30/15, 10:52
-
Stephan Großberndt voted on patch set 18 CR +1 V +1 06/30/15, 11:04
-
Andreas Kienast commented on patch set 18 07/01/15, 08:59
_.htaccess:304Should we add "composer.json" here, too? -
Stephan Großberndt commented on patch set 18 CR 0 07/01/15, 10:15
_.htaccess:304ReplyI think, thats a good idea. Markus? -
Stephan Großberndt uploaded patch set 19 07/01/15, 10:32
-
Stephan Großberndt commented on patch set 19 CR +1 V +1 07/01/15, 10:36
added composer.(json|lock) -
Markus Klein commented on patch set 19 CR +2 V +2 07/01/15, 10:38
Lets put that into master now. -
Markus Klein merged patch set 19 07/01/15, 10:38
-
Markus Klein commented on patch set 20 07/06/15, 12:27
_.htaccess:258This line causes troubles for me, when running in a subdirectory. Commenting it out, makes things working -
Markus Klein commented on patch set 20 07/06/15, 12:37
_.htaccess:258ReplySolved with https://review.typo3.org/40929 -
Patrik Karisch commented on patch set 20 06/01/17, 12:00
_.htaccess:348Why do you remove the ETag? -
Wouter Wolters commented on patch set 20 06/01/17, 12:23
_.htaccess:348Replysee explanation at https://github.com/h5bp/html5-boilerplate/blob/master/dist/.htaccess
_.htaccess:115