39257[CLEANUP] Replace deeply nested if structures by guard clauses
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 1
Review log 7
-
Bernhard Kraft uploaded patch set 1 05/04/15, 13:22
-
Markus Klein commented on patch set 1 05/04/15, 13:28
DataHandlerHook.php:1028; missingDataHandlerHook.php:1034move the assignment out of the conditionDataHandlerHook.php:1116add cast to (int)DataHandlerHook.php:1118===DataHandlerHook.php:1371if (empty($...)) -
Bernhard Kraft uploaded patch set 2 05/04/15, 18:24
-
Bernhard Kraft commented on patch set 2 05/04/15, 18:25
I ran the units tests after making all changes but didn't test it in a real instance. It wonders me the unit tests didn't find the missing ";" -
Markus Klein voted on patch set 2 CR +1 V +1 05/04/15, 21:09
-
Christian Kuhn commented on patch set 2 CR +2 V +2 05/05/15, 19:28
thx! btw: this one is very easy to read in gerrit if you "patch set preferences -> ignore whitespaces -> all" -
Christian Kuhn merged patch set 2 05/05/15, 19:28
DataHandlerHook.php:714