Review main Merged

39273[TASK] Add human readable sections names in Install Tool

Andreas Kienast CR +2 V +2 Normal +100 −1 updated 05/05/15, 19:39

Commit message

For usability reasons, prepend human readable sections names
in the "All Configuration" site of the Install Tool.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 12

  1. Andreas Kienast uploaded patch set 1 05/05/15, 06:25

  2. Andreas Kienast uploaded patch set 2 05/05/15, 06:26

  3. Mathias Schreiber voted on patch set 2 CR +1 V +1 05/05/15, 07:11

  4. Andreas Kienast uploaded patch set 3 05/05/15, 07:16

  5. Andreas Kienast uploaded patch set 4 05/05/15, 07:43

  6. Andreas Kienast commented on patch set 4 05/05/15, 07:45

    I also removed the "$TYPO3_CONF_VARS" now for two reasons: 1. the usage of this var is highly discouraged 2. from my pov this information is not required in the label
  7. Nicole Hummel commented on patch set 4 CR +1 V +1 05/05/15, 14:31

    KeyViewHelper.php:31

    I don't like the name - it doesn't tell what this view helper is doing.
  8. Christian Kuhn commented on patch set 4 CR -1 05/05/15, 18:45

    i'll work on that for a second
  9. Christian Kuhn uploaded patch set 5 05/05/15, 19:09

  10. Christian Kuhn commented on patch set 5 CR +1 V +1 05/05/15, 19:11

    renamed the VH a bit and implemented compilabeInterface (even if that is not too useful in install tool context).
  11. Anja Leichsenring voted on patch set 5 CR +2 V +2 05/05/15, 19:39

  12. Anja Leichsenring merged patch set 5 05/05/15, 19:39