Review main Merged

39289[TASK] Replace $TYPO3_CONF_VARS mentions EXT:install

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 05/06/15, 08:02

Commit message

The usage of $TYPO3_CONF_VARS is highly discouraged, replace the
mentions in the Install Tool with $GLOBALS['TYPO3_CONF_VARS'].

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stephan Großberndt +1
    • Markus Klein +1
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1

Issues 1

Files 3

Review log 10

  1. Andreas Kienast uploaded patch set 1 05/06/15, 07:22

  2. Markus Klein commented on patch set 1 05/06/15, 07:24

    Mail.html:17

    quotes here too?
  3. Andreas Kienast uploaded patch set 2 05/06/15, 07:25

  4. Andreas Kienast commented on patch set 1 05/06/15, 07:26

    Mail.html:17 Reply

    Done, good catch
  5. Christian Kuhn voted on patch set 2 CR +1 05/06/15, 07:28

  6. Wouter Wolters voted on patch set 2 CR +1 05/06/15, 07:30

  7. Markus Klein voted on patch set 2 CR +1 V +1 05/06/15, 07:41

  8. Stephan Großberndt voted on patch set 2 CR +1 05/06/15, 07:45

  9. Christian Kuhn voted on patch set 2 CR +2 V +2 05/06/15, 08:02

  10. Christian Kuhn merged patch set 2 05/06/15, 08:02