Review main Merged

39324[BUGFIX] ADOdb: mssqlnative driver is not properly initialized

Xavier Perseguers CR +2 V +2 Normal +54 −3 updated 05/07/15, 15:08

Commit message

Problems:

- Empty username/password should use Windows Authentication
- Character set is not used when connecting
- Port is not properly passed as argument

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Andreas Kienast +1
  • Verified V +2
    • Xavier Perseguers +2
    • Andreas Kienast +1

Issues 2

Files 3

Review log 6

  1. Xavier Perseguers uploaded patch set 1 05/07/15, 09:58

  2. Xavier Perseguers commented on patch set 1 CR -1 05/07/15, 10:22

    will fix another bug already reported at same time
  3. Xavier Perseguers uploaded patch set 2 05/07/15, 10:29

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 05/07/15, 12:42

  5. Xavier Perseguers voted on patch set 2 CR +2 V +2 05/07/15, 15:08

  6. Xavier Perseguers merged patch set 2 05/07/15, 15:08