Review main Merged

39331[TASK] Show edit icon on hovering the page title

Andreas Kienast CR +2 V +2 Easy +31 −14 updated 05/09/15, 00:07

Commit message

If an user hovers the page title in "List" or in "Page" module,
show an edit icon next to the page title to indicate an action.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1

Issues 1

Files 1

Review log 10

  1. Andreas Kienast uploaded patch set 1 05/07/15, 12:27

  2. Mathias Brodala commented on patch set 1 05/07/15, 14:18

    PageActions.js:47

    Can't you reuse the existing $editActionLink here?

    PageActions.js:49

    Same here.
  3. Andreas Kienast commented on patch set 1 05/07/15, 15:09

    PageActions.js:47 Reply

    Of course, it's a relict before I reoganised the code.
  4. Andreas Kienast uploaded patch set 2 05/07/15, 15:14

  5. Mathias Brodala commented on patch set 2 05/07/15, 15:56

    PageActions.js:44

    Git/Gerrit is slow: could you put this on a new line. ATM it's very easy to miss. Maybe also put it last, that won't break anything.
  6. Andreas Kienast uploaded patch set 3 05/07/15, 18:00

  7. Mathias Brodala uploaded patch set 4 05/08/15, 06:49

  8. Frank Nägler voted on patch set 4 V +1 CR +1 05/09/15, 00:05

  9. Christian Kuhn commented on patch set 4 CR +2 V +2 05/09/15, 00:06

    lol. how cool. actually i didn't knew this feature before ^^
  10. Christian Kuhn merged patch set 4 05/09/15, 00:07