39388[BUGFIX] Readonly fields must not render links to allowed tables
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Markus Klein +1
-
Verified V +2
- Christian Kuhn +2
- Markus Klein +1
Issues 1
Files 1
Review log 12
-
Georg Ringer uploaded patch set 1 05/09/15, 20:18
-
Susi Moog voted on patch set 1 V +1 CR +1 05/10/15, 16:33
-
Markus Klein commented on patch set 1 CR -1 05/10/15, 18:23
readOnly might not be set => empty()AbstractFormElement.php:729empty() and swap bodies -
Georg Ringer commented on patch set 1 05/11/15, 03:51
AbstractFormElement.php:729Replyhm I am not so sure about that change, the code is used several times like that in the same file already. so either change all or use the same method -
Markus Klein commented on patch set 1 05/11/15, 06:58
Will push an updateAbstractFormElement.php:729ReplyThat's a deficiency in those places then, but we must not introduce such bad code in new places, IMO. -
Markus Klein uploaded patch set 2 05/11/15, 07:04
-
Markus Klein voted on patch set 2 CR +1 V +1 05/11/15, 07:05
-
Christian Kuhn commented on patch set 2 CR -1 05/11/15, 10:30
working on it. -
Christian Kuhn commented on patch set 2 05/11/15, 10:37
i've added an example to ext:styleguide with group_12 -
Christian Kuhn voted on patch set 2 CR +2 V +2 05/11/15, 10:38
-
Christian Kuhn merged patch set 2 05/11/15, 10:39
-
Christian Kuhn commented on patch set 3 05/11/15, 10:52
georg, could you take care of the backport? the code is totally different in 6.2 and i have no idea where to search for it.