Review TYPO3_6-2 Merged

39425[TASK] Simplify PHP lint execution

Mathias Brodala CR +2 V +2 Easy +1 −6 updated 05/11/15, 10:45

Commit message

This simplifies PHP lint execution in Travis by ensuring lint
errors are outputted to stderr and drops everything else. If
any check fails, the exit code 1 is returned.

The Composer vendor directory is excluded from linting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1

Issues 1

Files 1

Review log 7

  1. Mathias Brodala uploaded patch set 1 05/11/15, 09:41

  2. Andreas Kienast voted on patch set 1 CR +1 V +1 05/11/15, 09:42

  3. Wouter Wolters voted on patch set 1 CR +1 05/11/15, 09:45

  4. Christian Kuhn voted on patch set 1 CR +2 V +2 05/11/15, 10:04

  5. Christian Kuhn merged patch set 1 05/11/15, 10:07

  6. Helmut Hummel commented on patch set 2 05/11/15, 10:44

    Any reasons that we do not want this also for master?
  7. Wouter Wolters commented on patch set 2 05/11/15, 10:45

    Is already in master:-)