Review main Merged

39443[TASK] Sane index length for "uid_foreign_tablefield"

Markus Klein CR +2 V +2 Easy +1 −1 updated 05/11/15, 16:55

Commit message

The index lengths for the fields "tablenames" and "fieldname"
of table "sys_category_record_mm" are way too big.
It suffices to have only few significant characters in the index.

We only take the first 40 characters of the tablename and the first
three characters of the fieldname as those should already be
distinctive enough to have a high quality index.
Assuming most table names are below 40 characters anyway and usually
only a few fields per table will be a category.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Stefan Froemken +2
    • Stephan Großberndt +1
  • Verified V +2
    • Andreas Kienast +2
    • Stefan Froemken +2

Issues 1

Files 1

Review log 9

  1. Markus Klein uploaded patch set 1 05/11/15, 14:21

  2. Markus Klein updated the commit message in patch set 2 05/11/15, 14:24

  3. Mathias Brodala voted on patch set 2 CR +1 05/11/15, 14:26

  4. Stefan Froemken commented on patch set 2 CR +2 V +2 05/11/15, 14:46

    I have tested it on InnoDB and MyISAM for MacOS, Ubuntu and CentOS. Works good. Thank you for your help.
  5. Stephan Großberndt updated the commit message in patch set 3 05/11/15, 14:46

  6. Stephan Großberndt voted on patch set 3 CR +1 05/11/15, 15:02

  7. Stefan Froemken voted on patch set 3 CR +2 V +2 05/11/15, 15:03

  8. Andreas Kienast voted on patch set 3 CR +2 V +2 05/11/15, 16:55

  9. Andreas Kienast merged patch set 3 05/11/15, 16:55