Review main Merged

39467[TASK] use include for checking update scripts

Jigal van Hemert CR +2 V +2 Easy +8 −7 updated 06/10/15, 16:21

Commit message

Instead of using eval() the EM includes temporary files with the
modified contents of class.ext_update.php to check if the update
script can be called.

Review

  • Code review CR +2
    • Markus Klein +2
    • Matthias Toscanelli +1
    • Xavier Perseguers +1
  • Verified V +2
    • Markus Klein +2
    • Matthias Toscanelli +1

Issues 1

Files 1

Review log 11

  1. Jigal van Hemert uploaded patch set 1 05/11/15, 21:18

  2. Jigal van Hemert commented on patch set 1 05/11/15, 21:24

    Still a problem if suhosin.executor.include.allow_writable_files is Off (TYPO3 will probably not work at all then), alternative could be to include ('data://text/plain,' . urlencode($scriptSourceCode)), but that could be blocked if suhosin.executor.include.blacklist and suhosin.executor.include.whitelist are both empty (default).
  3. Markus Klein voted on patch set 1 CR +1 05/11/15, 21:29

  4. Xavier Perseguers voted on patch set 1 CR +1 05/12/15, 05:26

  5. Matthias Toscanelli commented on patch set 1 V +1 CR +1 05/12/15, 08:34

    Clean solution
  6. Markus Klein commented on patch set 1 CR +2 V +2 05/12/15, 08:36

    lets get it in. Thanks.
  7. Markus Klein merged patch set 1 05/12/15, 08:37

  8. Markus Klein commented on patch set 2 05/12/15, 08:37

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 5496931eb43e49998f987466a11cd1264f6c1c64
  9. Markus Klein commented on patch set 2 06/10/15, 15:53

    UpdateScriptUtility.php:112

    One more issue with this thing. I just ran into it myself. having an update script which still contains a require_once you get a fatal, but no error message at all, nowhere! blank white EM. Ideas on how to deal with that?
  10. Xavier Perseguers commented on patch set 2 06/10/15, 16:02

    by debugging, any idea why it fatals? when it fatals, you should be able to read the actual error message, at least when using xdebug
  11. Markus Klein commented on patch set 2 06/10/15, 16:21

    after remvoign the @ Warning: Uncaught exception 'TYPO3\CMS\Core\Error\Exception' with message 'PHP Warning: require_once(PATH_t3libclass.t3lib_scbase.php): failed to open stream: