Review main Merged

39473[TASK] Deprecate $disable Option in PageRepository->getExtURL

Benni Mack CR +2 V +2 Easy +29 −4 updated 06/16/15, 11:51

Commit message

The disable option to check whether redirects are allowed
should be handled outside of the call to simplify code readability
and maintainability.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Frank Nägler +1
  • Verified V +2
    • Andreas Kienast +2
    • Frank Nägler +1

Issues 1

Files 3

Review log 11

  1. Benni Mack uploaded patch set 1 05/12/15, 04:14

  2. Andreas Kienast commented on patch set 1 05/12/15, 07:38

    PageRepository.php:725

    as you remove this now, it becomes a breaking, imo
  3. Benni Mack uploaded patch set 2 05/19/15, 04:39

  4. Frank Nägler commented on patch set 2 05/21/15, 08:25

    PageRepository.php:725

    imo a check like if ($disable !== FALSE) would be better.
  5. Frank Nägler uploaded patch set 3 05/21/15, 08:37

  6. Frank Nägler voted on patch set 3 V +1 CR +1 05/21/15, 08:52

  7. Wouter Wolters voted on patch set 3 CR +1 05/24/15, 12:49

  8. Andreas Kienast commented on patch set 3 CR -1 05/25/15, 11:36

    TypoScriptFrontendController.php:2793

    shouldn't this be TRUE? Previously, the value has been passed to the method and returned NULL if this was FALSE, the whole condition was false then. Now the value must be FALSE, which is different than before.
  9. Andreas Kienast commented on patch set 3 CR +1 06/16/15, 11:44

    TypoScriptFrontendController.php:2793 Reply

    After heavily thinking about it, this approach is correct
  10. Andreas Kienast voted on patch set 3 CR +2 V +2 06/16/15, 11:51

  11. Andreas Kienast merged patch set 3 06/16/15, 11:51