39473[TASK] Deprecate $disable Option in PageRepository->getExtURL
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Wouter Wolters +1
- Frank Nägler +1
-
Verified V +2
- Andreas Kienast +2
- Frank Nägler +1
Issues 1
Files 3
Review log 11
-
Benni Mack uploaded patch set 1 05/12/15, 04:14
-
Andreas Kienast commented on patch set 1 05/12/15, 07:38
-
Benni Mack uploaded patch set 2 05/19/15, 04:39
-
Frank Nägler commented on patch set 2 05/21/15, 08:25
PageRepository.php:725imo a check like if ($disable !== FALSE) would be better. -
Frank Nägler uploaded patch set 3 05/21/15, 08:37
-
Frank Nägler voted on patch set 3 V +1 CR +1 05/21/15, 08:52
-
Wouter Wolters voted on patch set 3 CR +1 05/24/15, 12:49
-
Andreas Kienast commented on patch set 3 CR -1 05/25/15, 11:36
TypoScriptFrontendController.php:2793shouldn't this be TRUE? Previously, the value has been passed to the method and returned NULL if this was FALSE, the whole condition was false then. Now the value must be FALSE, which is different than before. -
Andreas Kienast commented on patch set 3 CR +1 06/16/15, 11:44
TypoScriptFrontendController.php:2793ReplyAfter heavily thinking about it, this approach is correct -
Andreas Kienast voted on patch set 3 CR +2 V +2 06/16/15, 11:51
-
Andreas Kienast merged patch set 3 06/16/15, 11:51
PageRepository.php:725