Review main Merged Breaking

39475[!!!][TASK] Remove global configuration option GFX/png_to_gif

Benni Mack CR +2 V +2 Normal +58 −26 updated 05/19/15, 09:47

Commit message

The option png_to_gif was previously used to minimize
the size of generated images. In the current web development
png (with the support of all major browsers) has overtaken gif
functionality. The option, which was off by default for some
versions, has been removed. All calls to the actual "convert"
method in GraphicalFunction have been removed, the function
itself has been marked for deprecation.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 9

Review log 21

  1. Benni Mack uploaded patch set 1 05/12/15, 04:45

  2. Andreas Kienast commented on patch set 1 05/12/15, 05:42

    I guess we need a seperate Breaking.rst.
  3. Andreas Kienast commented on patch set 1 05/12/15, 05:44

    Deprecation-66906-FunctionalityPngToGifConversion.rst:30

    What? :)
  4. Benni Mack uploaded patch set 2 05/12/15, 09:27

  5. Xavier Perseguers voted on patch set 2 CR +1 05/13/15, 14:20

  6. Oliver Klee voted on patch set 2 CR +1 05/15/15, 09:01

  7. Andreas Kienast commented on patch set 2 CR -1 05/15/15, 10:04

    GraphicalFunctions.php:2626

    shouldn't it be "as the option has been removed with TYPO3 CMS 7", since it's removed in this patch?
  8. Georg Ringer voted on patch set 2 CR +1 V +1 05/15/15, 10:04

  9. Benni Mack uploaded patch set 3 05/15/15, 13:08

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 05/15/15, 13:19

  11. Markus Klein commented on patch set 3 05/15/15, 13:35

    GraphicalFunctions.php:2626

    has
  12. Markus Klein commented on patch set 3 05/15/15, 13:38

    Thinking about the deprecated function now, raises the question, if this is worth the deprecation. It will always return the file unmodified now. We could actually make this breaking and kick the function completely. In any case we could empty the function's body and just log the deprecation and return the file.
  13. Benni Mack uploaded patch set 4 05/15/15, 15:54

  14. Markus Klein commented on patch set 4 05/15/15, 16:21

    Was that only a rebase? I see no changes.
  15. Benni Mack commented on patch set 4 05/19/15, 03:01

    yes. sorry. only a rebase, no change. What do you think, Markus? I mean, keeping the function would not break existing extensions directly. I'm fine either way.
  16. Markus Klein commented on patch set 4 05/19/15, 09:27

    GraphicalFunctions.php:2626

    has
  17. Markus Klein uploaded patch set 5 05/19/15, 09:28

  18. Markus Klein voted on patch set 5 CR +1 V +1 05/19/15, 09:29

  19. Wouter Wolters voted on patch set 5 CR +1 05/19/15, 09:32

  20. Andreas Kienast voted on patch set 5 CR +2 V +2 05/19/15, 09:47

  21. Andreas Kienast merged patch set 5 05/19/15, 09:47