Review main Merged

39482[BUGFIX] Valid Content-Type header for jpg thumbnails

Stephan Großberndt CR +2 V +2 Easy +3 −3 updated 05/15/15, 12:53

Commit message

Use "Content-Type: image/jpeg" instead of invalid "image/jpg" derived
from the file extension. The invalid Content-Type in combination with
"X-Content-Type-Options: nosniff" leads to thumbnails not showing up in
Internet Explorer.

While at it also correct the case of "Etag" to "ETag".

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Frederic Gaus +1
    • Morton Jonuschat +1
    • Xavier Perseguers +1
  • Verified V +2
    • Andreas Kienast +2
    • Morton Jonuschat +1

Issues 1

Files 2

Review log 11

  1. Stephan Großberndt uploaded patch set 1 05/12/15, 11:08

  2. Stephan Großberndt updated the commit message in patch set 2 05/12/15, 11:09

  3. Wouter Wolters commented on patch set 2 05/12/15, 11:20

    Where in master is this in use? The class is deprecated and shouldn't be in use in the core anymore...
  4. Stephan Großberndt commented on patch set 2 05/12/15, 11:40

    It could well be that its not in use in master any more. I had that problem in a TYPO3 4.5.40 and found the code to be present in master too. Even if its not used and deprecated in master, the usage and thus the bug is still present in 6.2 then.
  5. Morton Jonuschat commented on patch set 2 05/12/15, 11:53

    Even though the class is deprecated and might not be used by the core anymore that's a long time to go with a bug that affects ThumbnailView, thumbs.php and BackendUtility::getThumbNail(). These functions/classes are probably still in use by a few extensions. Seeing that it's a no-brainer fix I'd reason not to keep a known bug in master
  6. Frederic Gaus voted on patch set 2 CR +1 05/12/15, 13:45

  7. Xavier Perseguers commented on patch set 2 CR +1 05/13/15, 14:41

    The class is marked as deprecated since 7.x but it should be bug free so I'm fine with that change and as said, bug exists then in 6.2
  8. Morton Jonuschat voted on patch set 2 CR +1 V +1 05/15/15, 06:45

  9. Andreas Kienast voted on patch set 2 V +1 CR +1 05/15/15, 12:32

  10. Andreas Kienast voted on patch set 2 CR +2 V +2 05/15/15, 12:53

  11. Andreas Kienast merged patch set 2 05/15/15, 12:53