Review main Abandoned

39503[FEATURE] Introduce bless for CSS splitting

Andreas Kienast CR 0 V 0 Impossible +11785 −11755 updated 05/15/15, 06:10

Commit message

Introduce bless as post-processor in Grunt, splitting the t3skin.css
into multiple files, as it has too many selectors for Internet Explorer
older than version 10. It's executed by running either `grunt` or
`grunt watch`.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 6

  1. Andreas Kienast uploaded patch set 1 05/12/15, 15:42

  2. Andreas Kienast uploaded patch set 2 05/12/15, 17:01

  3. Philipp Gampe commented on patch set 2 CR -1 05/12/15, 18:29

    The commit message deserves some words too. At least it should be clear why you introduce this feature (e.g. what problem is solved).

    Feature-66921-IntroduceBlessForCSSSplitting.rst:8

    line limit lengh here, please wrap the markup
  4. Andreas Kienast uploaded patch set 3 05/12/15, 18:39

  5. Andreas Kienast updated the commit message in patch set 4 05/12/15, 18:50

  6. Andreas Kienast abandoned the change 05/15/15, 06:10

    This patch does not solve the real problems and bypasses file compression on production level.