Review main Merged

39508[TASK] Cleanup of TYPO3\CMS\Core\Localization and Charset

Stephan Großberndt CR +2 V +2 Hard +285 −386 updated 05/15/15, 18:50

Commit message

* Make use of use-statements
* fix typos
* properly align comments
* fix PHPDoc
* fix bool signatures
* remove unused variables
* rename some cryptic variables
* check for equality using === and !== where possible
* use !empty() instead of count()

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 8

Review log 13

  1. Stephan Großberndt uploaded patch set 1 05/12/15, 20:38

  2. Stephan Großberndt uploaded patch set 2 05/12/15, 20:57

  3. Xavier Perseguers voted on patch set 2 CR +1 05/13/15, 07:41

  4. Stephan Großberndt commented on patch set 2 05/13/15, 08:03

  5. Andreas Kienast voted on patch set 2 CR +1 05/15/15, 12:16

  6. Markus Klein commented on patch set 2 05/15/15, 12:33

    CharsetConverter.php:929

    missing more spaces

    CharsetConverter.php:1907

    why can we remove that?
  7. Stephan Großberndt commented on patch set 2 05/15/15, 12:45

    CharsetConverter.php:929 Reply

    Done

    CharsetConverter.php:1907 Reply

    because its not used
  8. Stephan Großberndt uploaded patch set 3 05/15/15, 12:53

  9. Stephan Großberndt commented on patch set 2 05/15/15, 12:54

    Changes to CharsetConverter->UnumberToChar()
  10. Markus Klein voted on patch set 3 CR +1 V +1 05/15/15, 13:19

  11. Andreas Kienast voted on patch set 3 CR +1 05/15/15, 13:56

  12. Wouter Wolters voted on patch set 3 V +2 CR +2 05/15/15, 18:50

  13. Wouter Wolters merged patch set 3 05/15/15, 18:50