39508[TASK] Cleanup of TYPO3\CMS\Core\Localization and Charset
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 8
- typo3/sysext/core/Classes/Charset/CharsetConverter.php4+193 −303
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+15 −10
- typo3/sysext/core/Classes/Localization/Parser/LocallangArrayParser.php+12 −9
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php+11 −8
- typo3/sysext/core/Classes/Localization/Parser/XliffParser.php+3 −1
- typo3/sysext/core/Classes/Localization/LanguageStore.php+12 −8
- typo3/sysext/core/Classes/Localization/Locales.php+28 −41
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php+11 −6
Review log 13
-
Stephan Großberndt uploaded patch set 1 05/12/15, 20:38
-
Stephan Großberndt uploaded patch set 2 05/12/15, 20:57
-
Xavier Perseguers voted on patch set 2 CR +1 05/13/15, 07:41
-
Stephan Großberndt commented on patch set 2 05/13/15, 08:03
https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/62301465 -
Andreas Kienast voted on patch set 2 CR +1 05/15/15, 12:16
-
Markus Klein commented on patch set 2 05/15/15, 12:33
CharsetConverter.php:929missing more spacesCharsetConverter.php:1907why can we remove that? -
Stephan Großberndt commented on patch set 2 05/15/15, 12:45
CharsetConverter.php:929ReplyDoneCharsetConverter.php:1907Replybecause its not used -
Stephan Großberndt uploaded patch set 3 05/15/15, 12:53
-
Stephan Großberndt commented on patch set 2 05/15/15, 12:54
Changes to CharsetConverter->UnumberToChar() -
Markus Klein voted on patch set 3 CR +1 V +1 05/15/15, 13:19
-
Andreas Kienast voted on patch set 3 CR +1 05/15/15, 13:56
-
Wouter Wolters voted on patch set 3 V +2 CR +2 05/15/15, 18:50
-
Wouter Wolters merged patch set 3 05/15/15, 18:50