Review main Abandoned

39512[BUGFIX] Add locales en_US and en_GB

Stephan Großberndt CR 0 V 0 Easy +10 −0 updated 07/14/15, 18:36

Commit message

This patch adds English (UK) and English (US) to the core locales.
Without it custom languages would have to be added in
$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['user']
to be able to distinguish between british and american english.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 3

  1. Stephan Großberndt uploaded patch set 1 05/12/15, 21:02

  2. Xavier Perseguers commented on patch set 1 CR -2 05/13/15, 14:02

    This will make those locales freely available in Language module and request non-existing translation packages on our translation server for nothing since those locales are not configured/existing there. Furthermore, why not having de_CH and de_DE as well (could be useful). So generally speaking, I'm +1 for a better support for "common" locales but it should be done another way and not by adding new "pseudo-languages" to TYPO3. TYPO3 comes with a predefined and quite stuck list of supported languages, but I agree easy support of locales over those predefined languages should be supported much more easily than today.
  3. Xavier Perseguers abandoned the change 07/14/15, 18:36

    Thanks for suggesting this, as explained, for the time being we don't see a way to make it work properly and be supported officially due to too many external dependencies.