Review main Merged

39534[BUGFIX] Allow subclasses of \DateTime as entity properties

Stephan Schuler CR +2 V +2 Easy +42 −4 updated 08/13/15, 15:58

Commit message

When a class "\MyCustomDateTime extends \DateTime", the data mapper
creates "\DateTime" objects instead when mapping database results.
This patch uses the class annotation to resolve the class to create.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Daniel Goerz +1
    • Susi Moog +1
  • Verified V +2
    • Andreas Wolf +2
    • Daniel Goerz +1
    • Susi Moog +1

Issues 1

Files 3

Review log 11

  1. Stephan Schuler uploaded patch set 1 05/13/15, 13:24

  2. Wouter Wolters updated the commit message in patch set 2 05/19/15, 20:49

  3. Andreas Wolf uploaded patch set 3 08/05/15, 16:28

  4. Andreas Wolf voted on patch set 3 CR +1 V +1 08/05/15, 16:28

  5. Andreas Wolf uploaded patch set 4 08/05/15, 16:56

  6. Susi Moog voted on patch set 4 CR +1 V +1 08/05/15, 17:09

  7. Daniel Goerz voted on patch set 4 CR +1 V +1 08/05/15, 17:19

  8. Andreas Wolf voted on patch set 4 CR +2 V +2 08/05/15, 17:29

  9. Andreas Wolf merged patch set 4 08/05/15, 17:29

  10. Stephan Großberndt commented on patch set 5 08/12/15, 18:08

    TYPO3 6.2 is in Releases but the patch has not been backported. Is there a reason?
  11. Stephan Großberndt commented on patch set 5 08/13/15, 15:58