39566[TASK] Streamline table wizard
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stephan Großberndt +1
- Andreas Kienast +1
-
Verified V +2
- Wouter Wolters +2
- Andreas Kienast +1
Issues 1
Files 3
Review log 7
-
Benjamin Kott uploaded patch set 1 05/15/15, 12:31
-
Andreas Kienast voted on patch set 1 CR +1 V +1 05/15/15, 12:38
-
Stephan Großberndt commented on patch set 1 CR -1 05/15/15, 12:42
TableController.php:328calculate ($k + 1) * 2 beforehand storing it in a variable with a meaningful name?TableController.php:354$cells = array(''); insteadTableController.php:367!==TableController.php:384RemoveTableController.php:386$content = ' -
Wouter Wolters commented on patch set 1 V +2 CR +2 05/15/15, 12:49
@stephan I get your comments but this a change to improve the styling and not the code. Furthermore Benjamin is a frontend dev, let us do the changes to the code in a new patch. -
Stephan Großberndt voted on patch set 1 CR 0 05/15/15, 12:59
-
Stephan Großberndt voted on patch set 1 CR +1 05/15/15, 12:59
-
Wouter Wolters merged patch set 1 05/15/15, 13:00
TableController.php:308