Review main Merged

39578[TASK] Move texts from code to language file

Jigal van Hemert CR +2 V +2 Hard +175 −86 updated 07/18/15, 16:10

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Georg Ringer +1
    • Markus Klein +1
  • Verified V +2
    • Jigal van Hemert +2
    • Georg Ringer +1
    • Markus Klein +1

Issues 1

Files 2

Review log 11

  1. Jigal van Hemert uploaded patch set 1 05/16/15, 06:25

  2. Markus Klein commented on patch set 1 05/16/15, 12:12

    ExtensionManagerConfigurationUtility.php:323

    for the <br> you can use normal LF in the xlf file (white-space="preserve") and do a nl2br() here.
  3. Stefan Neufeind commented on patch set 1 CR -1 05/16/15, 21:17

    I'm with Markus about the newline. In other xlf-files we currently use xml:space="preserve" (looked it up).
  4. Jigal van Hemert uploaded patch set 2 07/17/15, 14:50

  5. Markus Klein commented on patch set 2 CR -1 07/17/15, 18:28

    rebase needed
  6. Markus Klein uploaded patch set 3 07/18/15, 14:43

  7. Markus Klein uploaded patch set 4 07/18/15, 14:45

  8. Markus Klein commented on patch set 4 CR +1 V +1 07/18/15, 14:45

    I changed that to master only, if that's ok with you.
  9. Georg Ringer voted on patch set 4 V +1 CR +1 07/18/15, 14:51

  10. Jigal van Hemert commented on patch set 4 CR +2 V +2 07/18/15, 16:10

    Enough votes
  11. Jigal van Hemert merged patch set 4 07/18/15, 16:10