Review main Merged Breaking

39586[FOLLOWUP][!!!][TASK] Rewrite ValueSlider to AMD module

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 05/17/15, 11:43

Commit message

The slider object bound to "renderTooltipValue" does not contain
the configuration set in the DOM by data attributes. Get the
element containing these attributes and us this instead.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Benjamin Kott +1
  • Verified V +2
    • Philipp Gampe +2
    • Benjamin Kott +1

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 05/17/15, 06:13

  2. Benjamin Kott voted on patch set 1 CR +1 V +1 05/17/15, 09:01

  3. Philipp Gampe voted on patch set 1 CR +1 V +1 05/17/15, 10:12

  4. Philipp Gampe voted on patch set 1 CR +2 V +2 05/17/15, 10:12

  5. Philipp Gampe merged patch set 1 05/17/15, 10:13

  6. Markus Klein commented on patch set 2 05/17/15, 11:43

    use

    ValueSlider.js:77

    why getting a jquery object, then fetching the DOM element again? $slider = $('[data-slider-id="' + this.id + '2]',