39586[FOLLOWUP][!!!][TASK] Rewrite ValueSlider to AMD module
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Benjamin Kott +1
-
Verified V +2
- Philipp Gampe +2
- Benjamin Kott +1
Issues 1
Files 1
Review log 6
-
Andreas Kienast uploaded patch set 1 05/17/15, 06:13
-
Benjamin Kott voted on patch set 1 CR +1 V +1 05/17/15, 09:01
-
Philipp Gampe voted on patch set 1 CR +1 V +1 05/17/15, 10:12
-
Philipp Gampe voted on patch set 1 CR +2 V +2 05/17/15, 10:12
-
Philipp Gampe merged patch set 1 05/17/15, 10:13
-
Markus Klein commented on patch set 2 05/17/15, 11:43
useValueSlider.js:77why getting a jquery object, then fetching the DOM element again? $slider = $('[data-slider-id="' + this.id + '2]',