Review main Abandoned

39595[FEATURE][WIP] Add language check hook

Sebastian Fischer CR 0 V 0 Normal +70 −28 updated 03/13/16, 19:25

Commit message

With this hook its possible to have additional language access checks

Review

  • Code review CR 0
  • Verified V 0

Files 14

Review log 10

  1. Sebastian Fischer uploaded patch set 1 05/18/15, 10:18

  2. Frank Nägler commented on patch set 1 05/18/15, 11:40

    can we solve this with a signal instead of hook?
  3. Nicole Hummel commented on patch set 1 05/18/15, 11:49

    BackendUserAuthentication.php:677

    IMHO it would be better to pass the record array to the user function

    BackendUserAuthentication.php:687

    All other hooks use 't3lib/class.t3lib_userauthgroup.php' as key. Not sure if we should stay to this key to streamline the API
  4. Frank Nägler commented on patch set 1 05/18/15, 12:02

    as discussed in slack, hook is ok in this case.
  5. Sebastian Fischer uploaded patch set 2 05/18/15, 12:18

  6. Nicole Hummel commented on patch set 2 05/18/15, 12:30

    BackendUserAuthentication.php:674

    Array with record information
  7. Benni Mack commented on patch set 2 CR -1 08/07/15, 12:30

    Please adapt all places in the core as well, and provide a RsT file that this is a breaking change.
  8. Sebastian Fischer uploaded patch set 3 09/07/15, 09:09

  9. Benni Mack commented on patch set 3 CR -1 03/05/16, 23:54

    Sebastian, are you going to update this review? Otherwise I suggest we abandon this patch for the time being (we could restore it later again)
  10. Sebastian Fischer abandoned the change 03/13/16, 19:25

    For the time being i drop this review to make room to another approach.