39595[FEATURE][WIP] Add language check hook
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 14
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormContainerContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormLanguageContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/Commands.php+1 −1
- typo3/sysext/backend/Classes/Tree/Pagetree/PagetreeNode.php+9 −9
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php3+19 −6
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-69517-Add-language-check-hook.rstnew+29 −0
- typo3/sysext/frontend/Classes/View/AdminPanelView.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+2 −2
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+1 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+2 −2
Review log 10
-
Sebastian Fischer uploaded patch set 1 05/18/15, 10:18
-
Frank Nägler commented on patch set 1 05/18/15, 11:40
can we solve this with a signal instead of hook? -
Nicole Hummel commented on patch set 1 05/18/15, 11:49
BackendUserAuthentication.php:677IMHO it would be better to pass the record array to the user functionBackendUserAuthentication.php:687All other hooks use 't3lib/class.t3lib_userauthgroup.php' as key. Not sure if we should stay to this key to streamline the API -
Frank Nägler commented on patch set 1 05/18/15, 12:02
as discussed in slack, hook is ok in this case. -
Sebastian Fischer uploaded patch set 2 05/18/15, 12:18
-
Nicole Hummel commented on patch set 2 05/18/15, 12:30
BackendUserAuthentication.php:674Array with record information -
Benni Mack commented on patch set 2 CR -1 08/07/15, 12:30
Please adapt all places in the core as well, and provide a RsT file that this is a breaking change. -
Sebastian Fischer uploaded patch set 3 09/07/15, 09:09
-
Benni Mack commented on patch set 3 CR -1 03/05/16, 23:54
Sebastian, are you going to update this review? Otherwise I suggest we abandon this patch for the time being (we could restore it later again) -
Sebastian Fischer abandoned the change 03/13/16, 19:25
For the time being i drop this review to make room to another approach.