Review main Merged

3960[FEATURE] Group HttpExceptions by Error type

Steffen Gebert CR +2 V +2 Normal +87 −5 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Stefan Neufeind +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Xavier Perseguers +1

Issues 1

Files 8

Review log 9

  1. Stefan Neufeind commented on patch set 1 08/02/11, 07:07

    Looks good to me, but someone else must approve Errors grouped into client- and server-errors. Quite a small change. Just one more class-inheritance-level inbetween in the hierarchy.
  2. Xavier Perseguers commented on patch set 1 08/02/11, 07:07

    Looks good to me, but someone else must approve
  3. Xavier Perseguers voted on patch set 1 V 0 08/02/11, 07:07

  4. Steffen Gebert commented on patch set 1 08/02/11, 07:07

    This is a prerequisite for Ic187d51c
  5. Steffen Gebert commented on patch set 1 08/02/11, 07:07

    (1 inline comment)
  6. Steffen Gebert commented on patch set 1 V 0 08/02/11, 07:07

    by team member; Looks good to me, approved Merging, as the dependence (Ic187d51c) was merged and Gerrit did *not* wait for this one here (after talking to Xavier)
  7. Philipp Gampe commented on patch set 1 08/02/11, 07:07

    Looks good to me, but someone else must approve

    core_autoload.php:137

    do we need autoload for abstract classes?
  8. Mr. Jenkins commented on patch set 1 08/02/11, 07:07

  9. Steffen Gebert merged patch set 1 08/02/11, 07:07