Review main Merged

39600[BUGFIX] felogin: Use correct regex in redirect evaluation

Markus Klein CR +2 V +2 Easy +22 −2 updated 05/18/15, 18:16

Commit message

Review

  • Code review CR +2
    • Markus Klein +2
    • Stephan Großberndt +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 10

  1. Markus Klein uploaded patch set 1 05/18/15, 17:28

  2. Christian Kuhn commented on patch set 1 05/18/15, 17:38

    standard question: any chance to have a small unit test for that? should be relatively easy with an AccessibleMock at first glance ...
  3. Markus Klein uploaded patch set 2 05/18/15, 17:54

  4. Stephan Großberndt commented on patch set 2 CR -1 05/18/15, 17:59

    FrontendLoginControllerTest.php:16

    missing newline
  5. Christian Kuhn uploaded patch set 3 05/18/15, 18:05

  6. Christian Kuhn voted on patch set 3 CR +1 V +1 05/18/15, 18:05

  7. Stephan Großberndt voted on patch set 3 CR +1 05/18/15, 18:07

  8. Markus Klein voted on patch set 3 CR +2 V +2 05/18/15, 18:16

  9. Markus Klein merged patch set 3 05/18/15, 18:16

  10. Markus Klein commented on patch set 4 05/18/15, 18:16

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 31b46dd7f74703c00c94a562be72b8abe4a6e1f0