Review main Merged

39628[BUGFIX] PropertyMapper now normalizes simple types

Wouter Wolters CR +2 V +2 Easy +28 −14 updated 06/05/15, 13:06

Commit message

This fixes a bug where the property mapper was unable to find a
valid typeconverter for properties annotated with int or bool.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1

Issues 1

Files 2

Review log 15

  1. Wouter Wolters uploaded patch set 1 05/20/15, 09:01

  2. Andreas Kienast commented on patch set 1 CR +1 V +1 05/20/15, 09:10

    The change looks valid. Verified by unit tests.
  3. Mathias Brodala voted on patch set 1 CR +1 05/20/15, 09:35

  4. Markus Klein voted on patch set 1 CR +1 05/20/15, 09:35

  5. Mathias Brodala commented on patch set 1 CR -1 05/20/15, 09:37

    PropertyMapper.php:213

    Since $targetType is not used separately anywhere else afterwards, we can just overwrite it.
  6. Wouter Wolters commented on patch set 1 05/20/15, 11:33

    PropertyMapper.php:213 Reply

    you are allowed to push a new patch here, I only pushed the same code as in Flow, see Forge ticket for the correct link to that code.
  7. Mathias Brodala uploaded patch set 2 05/20/15, 11:56

  8. Markus Klein voted on patch set 2 CR +1 05/20/15, 12:31

  9. Helmut Hummel voted on patch set 2 CR +1 05/30/15, 13:23

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 05/31/15, 18:12

  11. Markus Klein voted on patch set 2 CR +2 V +2 06/04/15, 13:29

  12. Markus Klein merged patch set 2 06/04/15, 13:29

  13. Mathias Brodala commented on patch set 3 06/05/15, 12:57

    A similar fix has been applied just now in TYPO3.Flow but in the ReflectionService: https://git.typo3.org/Packages/TYPO3.Flow.git/commit/ec8601c7c7a9977d0a172254bb4263c720713c3f
  14. Wouter Wolters commented on patch set 3 06/05/15, 13:05

    Flow has a completely different reflection service.. can;t find this specific piece of code.
  15. Mathias Brodala commented on patch set 3 06/05/15, 13:06

    Yes, just wanted to add this as reference.