Review main Merged

39630[BUGFIX] Fix translated shortcut target in menus

Mathias Brodala CR +2 V +2 Easy +2 −2 updated 11/29/19, 07:10

Commit message

This ensures that the target of translated "shortcut" pages is
properly available. Normally this value is lost due to language
overlay thus the original page record needs to be retrieved to
restore the original shortcut target.

Now it is possible to e.g. mark shortcut menu items as active
on translated pages.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 4043

Show 18 earlier messages
  1. Mathias Brodala uploaded patch set 1 05/20/15, 10:24

  2. Mathias Brodala uploaded patch set 2 05/20/15, 11:09

  3. Markus Klein voted on patch set 2 CR +1 V +1 05/20/15, 11:16

  4. Christian Kuhn commented on patch set 2 05/20/15, 11:29

    how risky is this for 6.2? could it possibly have effects a bugfix upgrader may not have foreseen? could it change existing menus easily in casual use cases?
  5. Markus Klein commented on patch set 2 05/20/15, 11:46

    To my judgement I see no risk, since you explicitly need to query the 'shortcut' field in the data. This is not done by default anywhere.
  6. Mathias Brodala commented on patch set 2 05/20/15, 11:50

    What Markus said. You won't notice this change unless you directly use the "shortcut" field in your menu TypoScript code. If you did that, you only got "0" for the mentioned case, now you get the actual value. Thus it's very unlikely to break existing code.
  7. Christian Kuhn commented on patch set 2 05/20/15, 12:58

    ok. thx 4 analysis. so fine with me with 6.2 backport.
  8. Mathias Brodala commented on patch set 2 06/05/15, 11:48

    Markus Sommer pointed out that you can alternatively fix this, if you re-set the shortcut target in every page translation. Is this the expected and correct behavior?
  9. Markus Sommer commented on patch set 2 CR -1 V -1 06/05/15, 11:49

    The problem occurs when you set no target for the reference to the translated page only.
  10. Markus Klein voted on patch set 2 CR 0 V 0 06/05/15, 12:02

  11. Markus Klein commented on patch set 2 10/09/15, 00:04

    please proceed here
  12. Oliver Hader uploaded patch set 3 10/09/15, 06:12

  13. Markus Sommer voted on patch set 3 CR +1 V +1 02/12/16, 11:34

  14. Markus Klein wrote 02/12/16, 11:46

    Patch set 4: Commit message was updated.
  15. Markus Klein voted on patch set 4 CR +1 V +1 02/12/16, 11:48

  16. Frank Nägler voted on patch set 4 CR +1 02/29/16, 09:16

  17. Andreas Wolf commented on patch set 4 V -1 03/04/16, 07:24

    I’m not sure about the actual impact of this change. Do I get it right, that it ignores either the page type or the shortcut settings of translated pages and resorts back to the original page’s settings? Is there a possible overlap with my changes to #66932 (which change the PageRepository, not the menu CObject). I could not reproduce the issue on my machine, hence the -1 on testing.
  18. Mathias Brodala commented on patch set 4 03/04/16, 12:13

    > I’m not sure about the actual impact of this change. Do I get it > right, that it ignores either the page type or the shortcut > settings of translated pages and resorts back to the original > page’s settings? It ensures that the shortcut target of the default language is used if not set in a translation. This was already the case before for the actual link but not for the menu item states. > Is there a possible overlap with my changes to > #66932 (which change the PageRepository, not the menu CObject). > I could not reproduce the issue on my machine, hence the -1 on > testing. You only need a regular menu and at least one shortcut page with a target. Unless you set the same target in all translations, the menu item for this shortcut page won't get the ACT state on translated page versions. Does your fix also cover this usecase?
  1. Andreas Wolf commented on patch set 4 CR +1 V 0 03/04/16, 15:30

    Thanks for the explanation, Mathias. As I could not really test this, I cannot confirm that my patch also fixes the issue, but I’d be glad to get your feedback on that, in case you still have the test setup available. For now, I’ll revoke my -1. The code looks good, but as said, I cannot test due to a missing test case on my machine.
  2. Anja Leichsenring commented on patch set 4 V -1 03/04/16, 16:53

    on it. But for sure, this patch will not be backported to 6.2.
  3. Nicole Hummel commented on patch set 4 CR -1 03/04/16, 16:54

    on it
  4. Nicole Hummel voted on patch set 4 CR +1 03/04/16, 17:01

  5. Andreas Wolf uploaded patch set 5 03/04/16, 17:25

  6. Andreas Wolf commented on patch set 5 CR -1 03/04/16, 17:36

    Still discussing this with Anja.
  7. Anja Leichsenring commented on patch set 5 V -1 03/04/16, 17:44

    This patch only works for shortcut mode 'selected page' with an explicitly set target uid. If one uses any other mode like parent page, the item is not marked. This needs to be tackled as well. Second, this patch changes behaviour and therefor is only fitted to be applied to master. I vote against backports in stable branches.
  8. Mathias Schreiber updated the commit message in patch set 6 04/09/16, 20:38

  9. Mathias Schreiber commented on patch set 6 04/09/16, 20:39

    Let's get on with this :) Marked as WIP for the time being
  10. Tymoteusz Motylewski wrote 10/29/16, 21:21

    Topic set to l10n
  11. TYPO3com voted on patch set 6 V +1 12/04/16, 10:38 Completed build in 05m 58s on Sun, 4 Dec, 11:38 AM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5452

  12. Alexander Opitz commented on patch set 6 01/18/18, 13:08

    *ping* Any progress here?
  13. Benni Mack commented on patch set 6 09/04/18, 06:06

    hey mathias. still an issue here? Releases says master+7.6 ;)
  14. Mathias Brodala commented on patch set 6 09/04/18, 09:40

    > hey mathias. still an issue here? Releases says master+7.6 ;) Just checked and yes, the issue still exists in v8 and the latest master.
  15. Benni Mack updated the commit message in patch set 7 11/08/18, 20:13

  16. TYPO3com voted on patch set 7 V +1 11/08/18, 20:37 Completed build in 14m 44s on Thu, 8 Nov, 09:37 PM Test Summary: 48468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30091

  17. Benni Mack updated the commit message in patch set 8 12/14/18, 10:08

  18. Benni Mack commented on patch set 8 12/14/18, 10:08

    Updated the releases line, please re-apply your votes
  19. Benni Mack commented on patch set 8 03/23/19, 21:39

    Hey Mathias, any reason why this is still marked as WIP?
  20. Anja Leichsenring wrote 09/09/19, 08:41

    Removed reviewer Anja Leichsenring.
  21. Benni Mack uploaded patch set 9 11/08/19, 14:27

  22. TYPO3com voted on patch set 9 V +1 11/08/19, 14:39 Completed build in 12m 02s on Fri, 8 Nov, 02:39 PM Test Summary: 48147 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-38120

  23. Benni Mack voted on patch set 9 V +1 CR +1 11/09/19, 17:08

  24. Susi Moog voted on patch set 9 V +2 CR +2 11/29/19, 07:10

  25. Susi Moog merged patch set 10 11/29/19, 07:10