Review main Merged

39634[TASK] Make fileedit hook JavaScript for ext:t3editor an AMD module

Wouter Wolters CR +2 V +2 Normal +52 −48 updated 05/20/15, 21:44

Commit message

Review

  • Code review CR +2
    • Frank Nägler +2
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 3

Review log 6

  1. Wouter Wolters uploaded patch set 1 05/20/15, 18:52

  2. Markus Klein commented on patch set 1 CR -1 05/20/15, 21:16

    will push an update

    FileEdit.js:60

    Completely reduce this. Actually we don't even need the FileEdit object. just put the plain ready-function in here and do not even return anything. There is not module that builds upon this one.
  3. Markus Klein uploaded patch set 2 05/20/15, 21:20

  4. Markus Klein voted on patch set 2 CR +1 V +1 05/20/15, 21:22

  5. Frank Nägler voted on patch set 2 V +2 CR +2 05/20/15, 21:44

  6. Frank Nägler merged patch set 2 05/20/15, 21:44