Review main Merged

39645[BUGFIX] Use strict comparison for EXT:mediace arrays

Benni Mack CR +2 V +2 Easy +7 −7 updated 05/21/15, 12:39

Commit message

Due to strict warnings it is not possible to use media content elements
anymore and add a simple youtube video, as a fatal is thrown here.

The change modifies the array check to be stricter.

Review

  • Code review CR +2
    • Benni Mack +2
    • Oliver Klee +1
    • Sebastian Michaelsen +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Andreas Kienast +1
    • Cedric Ziel +1
  • Verified V +2
    • Benni Mack +2
    • Sebastian Michaelsen +1
    • Andreas Kienast +1

Issues 1

Files 3

Review log 9

  1. Benni Mack uploaded patch set 1 05/21/15, 07:05

  2. Sebastian Michaelsen voted on patch set 1 CR +1 V +1 05/21/15, 07:14

  3. Wouter Wolters voted on patch set 1 CR +1 05/21/15, 07:39

  4. Cedric Ziel voted on patch set 1 CR +1 05/21/15, 08:17

  5. Andreas Kienast voted on patch set 1 CR +1 V +1 05/21/15, 08:23

  6. Oliver Klee voted on patch set 1 CR +1 05/21/15, 10:13

  7. Stephan Großberndt voted on patch set 1 CR +1 05/21/15, 12:36

  8. Benni Mack voted on patch set 1 CR +2 V +2 05/21/15, 12:39

  9. Benni Mack merged patch set 1 05/21/15, 12:39