Review main Merged

39648[BUGFIX] Check page access only if integer in ModuleRunner

Nicole Hummel CR +2 V +2 Easy +3 −2 updated 05/21/15, 14:17

Commit message

If you register a module in main module "file" an error is thrown
because the ModuleRunner checks page access for the variable "id".
In any file module the id is a FAL identifier which can't be converted
to an integer value and the check fails.

This patch adds a limitation to the ModuleRunner to check page access
only if the id can be interpreted as integer value.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Markus Sommer +1
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Markus Sommer +1

Issues 1

Files 1

Review log 8

  1. Nicole Hummel uploaded patch set 1 05/21/15, 11:26

  2. Markus Sommer voted on patch set 1 CR +1 V +1 05/21/15, 13:40

  3. Andreas Kienast voted on patch set 1 CR +1 05/21/15, 13:59

  4. Markus Klein voted on patch set 1 CR +1 V +1 05/21/15, 14:07

  5. Wouter Wolters voted on patch set 1 CR +1 05/21/15, 14:11

  6. Markus Klein voted on patch set 1 CR +2 V +2 05/21/15, 14:17

  7. Markus Klein merged patch set 1 05/21/15, 14:17

  8. Markus Klein commented on patch set 2 05/21/15, 14:17

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 71da923a6baf1fa3d424222ca90c76a58f2aa51f